[show tech] fix more bash script format#1846
Merged
yxieca merged 2 commits intosonic-net:masterfrom Sep 30, 2021
Merged
Conversation
These format are not wrong. But if error_handler for $? is installed, these places would cause fase positives. Signed-off-by: Ying Xie <[email protected]>
qiluo-msft
previously approved these changes
Sep 29, 2021
qiluo-msft
approved these changes
Sep 29, 2021
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
These format are not wrong. But if error_handler for $? is installed, these places would cause fase positives.
How I did it
Update more bash syntax to avoid false positives
How to verify it
Run show tech support test before merge.
Signed-off-by: Ying Xie [email protected]