[portstat] check TX/RX utilization calculation correctness#1840
[portstat] check TX/RX utilization calculation correctness#1840qiluo-msft merged 1 commit intosonic-net:masterfrom
Conversation
|
@ayurkiv-nvda could you please specify on which branches this fix should be taken? |
Problem related to this fix appeared after merging 1750 |
|
@ganglyu, did you have a chance to take a look at these changes? |
Will take a look soon. |
|
Converting this PR to draft because additional investigation showed that "brate" already in octets, and "port_rate" in bits so calculation |
ayurkiv-nvda
dismissed stale reviews from ganglyu and liat-grozovik
via
c411bba
ayurkiv-nvda
force-pushed
the
porstat_fix_azure
branch
2 times, most recently
from
c411bba to
25db0d2
Compare
ayurkiv-nvda
changed the title
ayurkiv-nvda
force-pushed
the
porstat_fix_azure
branch
from
25db0d2 to
8c761fd
Compare
ayurkiv-nvda
changed the title
Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
ayurkiv-nvda
force-pushed
the
porstat_fix_azure
branch
from
8c761fd to
948d1d7
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@qiluo-msft any further comments on this PR that should be followed? |
|
@qiluo-msft kindly reminder. Can you please review? |
#### What I did Update test for checking TX/RX utilization #### How I did it Add real values for TX/RX to mock table instead of zeroes #### How to verify it run **portstat_test.py** via `python3 setup.py test` in sonic-utilities tests
6 participants
What I did
Update test for checking TX/RX utilization
How I did it
Add real values for TX/RX to mock table instead of zeroes
How to verify it
run portstat_test.py via
python3 setup.py testin sonic-utilities testsPrevious command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)