[aclshow]: Add aclshow utility to view ACL info and counters#18
Merged
stcheng merged 5 commits intosonic-net:masterfrom Apr 5, 2017
Merged
[aclshow]: Add aclshow utility to view ACL info and counters#18stcheng merged 5 commits intosonic-net:masterfrom
stcheng merged 5 commits intosonic-net:masterfrom
Conversation
jleveque
suggested changes
Mar 23, 2017
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
Please also add this script to the Python package build under "scripts=[...]" in setup.py.
scripts/aclshow
Outdated
| self.validate_ports() | ||
|
|
||
| def setup_db_connections(self): | ||
|
|
scripts/aclshow
Outdated
| print("ACL Tables to show:", len(self.acl_tables)) | ||
|
|
||
| def fetch_acl_rules(): | ||
|
|
stcheng
suggested changes
Mar 23, 2017
Contributor
stcheng
left a comment
stcheng
left a comment
There was a problem hiding this comment.
https://github.com/Azure/sonic-py-swsssdk this is the library to connect to the db. I think it is better to use the library to connect and hide all the db functions behind the library so that the script here only calls limited intuitive APIs.
Collaborator
|
Build triggered. sha1 is merged. |
Collaborator
|
Build started sha1 is merged. |
Collaborator
|
No test results found. |
Collaborator
Author
|
Updated. Now we need sswsdk on switch |
lguohan
approved these changes
Mar 27, 2017
|
Can we merge this tool and update submodule pointers? |
Contributor
stcheng
approved these changes
Apr 4, 2017
jleveque
approved these changes
Apr 5, 2017
jleveque
suggested changes
Apr 5, 2017
scripts/aclshow
Outdated
Contributor
There was a problem hiding this comment.
Should change from sswsdk.SonicV2Connector() to swsssdk.SonicV2Connector() to work with new module name.
jleveque
approved these changes
Apr 5, 2017
samaity
added a commit
to samaity/sonic-utilities
that referenced
this pull request
Mar 19, 2020
…es. (sonic-net#18) Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
[sfp_util] open eeprom files with buffering disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.