[acl_loader]: Add status column to session table#177
Merged
lguohan merged 1 commit intosonic-net:masterfrom Dec 19, 2017
Merged
[acl_loader]: Add status column to session table#177lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: marian-pritsak <[email protected]>
Contributor
|
This commit will break below command. It hangs and never exits. Further more, it will break ACL Test playbook. It also hangs. |
3 tasks
vdahiya12
pushed a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Jul 23, 2021
#### Description
1. Currently in sonic, for 400G pre-emphasis settings is not programmed via common methodology.
We use Vendor Name + PN to program which would consume memory and never ending process as we need to add Vendor name + PN for every optic.
2. For 100G/40G optics, specification compliance is not displayed. Only for DAC, the specification compliance was displayed.
#### Motivation and Context
1. With this PR, we can program the pre-emphasis settings for both DAC,AOC and optics.
QSFP_DD parser doesn't have specification compliance which was need to program pre-emphasis settings.
The platform API code can be changed to return the type_of_media_interface for 400G media specification compliance, so that the type of media can be determined.
https://github.com/Azure/sonic-platform-common/blob/a95834b65a9f3b17ab1ce4e1ba5d1a60102e4507/sonic_platform_base/sonic_sfp/sff8024.py#L104
2. To address 100G/40G optic, introduced a new key "QSFP28 - *" / "QSFP+ - *" (type_abbrv_name followed by a hyphen) .
The same key can be defined in vendor specific media_settings.json.
These changes doesn't modify the existing behavior but additionally addresses the above mentioned issues.
Vendors can still add "Vendor_name + PN" in media_settings.json to program media settings if needed.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
[RFC4292][Namespace][201911]: Fix implementation of RouteUpdater for multi-asic platform (sonic-net#177) Signed-off-by: Abhishek Dosi <[email protected]>
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
… in SFP plugin (sonic-net#177) - Import of sonic_platform before logger when platform API is not available leads to non import of logger resulting in xcvrd crash - Since string and byte comparison returns true in python2 current check for differentiating python2 and 3 in EEPROM read fails. Co-authored-by: V P Subramaniam <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
May 20, 2025
Signed-off-by: Nazarii Hnydyn <[email protected]> <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "closes #xxxx", "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related issue when the PR is merged. If you are adding/modifying/removing any command or utility script, please also make sure to add/modify/remove any unit tests from the tests directory as appropriate. If you are modifying or removing an existing 'show', 'config' or 'sonic-clear' subcommand, or you are adding a new subcommand, please make sure you also update the Command Line Reference Guide (doc/Command-Reference.md) to reflect your changes. Please provide the following information: --> **DEPENDS:** 1. sonic-net/sonic-swss-common#1001 **HLD:** sonic-net/SONiC#1898 #### What I did * Implemented CLI for Packet Trimming feature #### How I did it * Integrated Packet Trimming interface into `config` and `show` CLI root #### How to verify it 1. Run Packet Trimming CLI UTs #### Previous command output (if the output of a command-line utility has changed) * N/A #### New command output (if the output of a command-line utility has changed) * N/A #### A picture of a cute animal (not mandatory but encouraged) ``` .---. .----------- / \ __ / ------ / / \( )/ ----- ////// ' \/ ` --- //// / // : : --- // / / /` '-- // //..\\ ====UU====UU==== '//||\\` ''`` ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: marian-pritsak [email protected]