disk_check: Script updated#1747
Merged
renukamanavalan merged 2 commits intosonic-net:masterfrom Aug 24, 2021
Merged
Conversation
Changes: 1) Individual subdirs for each dir to be mounted 2) subprocess args to be in sync with python3 version in 201811 & 201911
Contributor
|
@qiluo-msft , can you take priority to review this one? |
qiluo-msft
reviewed
Aug 18, 2021
|
|
||
| if proc.stdout: | ||
| log_info("stdout: {}".format(str(proc.stdout))) | ||
| log_info("stdout: {}".format(proc.stdout.decode("utf-8"))) |
Contributor
Contributor
Author
There was a problem hiding this comment.
Prefer to keep it explicit. Any issue with that.
qiluo-msft
reviewed
Aug 18, 2021
| "mounts": "overlay_tmpx blahblah", | ||
| "err": "/tmpx is not read-write|READ-ONLY: Mounted ['/tmpx'] to make Read-Write", | ||
| "cmds": ['mount -t overlay overlay_tmpx -o lowerdir=/tmpx,upperdir=/tmp/tmpx,workdir=/tmp/tmpy /tmpx'] | ||
| "cmds": ['mount -t overlay overlay_tmpx -o lowerdir=/tmpx,upperdir=/tmp/tmpx/tmpx,workdir=/tmp/tmpy/tmpx /tmpx'] |
Contributor
Contributor
Author
There was a problem hiding this comment.
This is a base change. We use explicit subdir under upper & work for each dir to mount.
qiluo-msft
approved these changes
Aug 24, 2021
Contributor
qiluo-msft
left a comment
qiluo-msft
left a comment
There was a problem hiding this comment.
Could you refine the PR title (and the title during squash merge)? It is not clear what you plan to adopt? Audience know nothing about 201811/201911 adoption requirement. I guess you mean adapt code to be compatible with python2?
renukamanavalan
changed the title
renukamanavalan
added a commit
to renukamanavalan/sonic-utilities
that referenced
this pull request
Oct 11, 2021
…1747) What I did Have independent subdirs for each mounted dir to avoid any collisions of files/dirs by same name. Adopt for older version of python3 How I did it Changes: Individual subdirs for each dir to be mounted subprocess args made compatible with older version of python3 (tested in version 3.5.3) How to verify it Simulate read-only state Run this script Test ssh via new tacacs user (who had not logged in earlier)
renukamanavalan
added a commit
to renukamanavalan/sonic-utilities
that referenced
this pull request
Oct 11, 2021
…1747) What I did Have independent subdirs for each mounted dir to avoid any collisions of files/dirs by same name. Adopt for older version of python3 How I did it Changes: Individual subdirs for each dir to be mounted subprocess args made compatible with older version of python3 (tested in version 3.5.3) How to verify it Simulate read-only state Run this script Test ssh via new tacacs user (who had not logged in earlier)
yxieca
pushed a commit
that referenced
this pull request
Oct 15, 2021
…ly (#1873) * disk_check: Check & mount RO as RW using tmpfs (#1569) What I did There is a bug that occasionally turn root-overlay as RO. This makes /etc & /home as RO. This blocks any new remote user login, as that needs to write into /etc & /home. This tool scans /etc & /home (or given dirs) as in RW or RO state. If RO, it could create a writable overlay using tmpfs. This is transient and stays until next reboot. Any write after the overlay will be lost upon reboot. But this allows new remote users login. How I did it Create upper & work dirs in /run/mount (tmpfs). Mount /etc & /home as lowerdirs and use the same name for final merge. This allows anyone opening a file in /etc or /home to operate on the merged overlay, transparently. How to verify it Mount any dir on tmpfs ( mount -t tmpfs tmpfs test_dir) remount as RO (mount -o remount,ro test_dir) Pass that dir to this script. (disk_check.py -d ./test_dir) Now it should be RW * disk_check updates: (#1736) 1) Set default loglevel to SYSLOG_ERR 2) Make log level configurable via args * disk_check: Script updated to run good in 201811 & 201911 (#1747) What I did Have independent subdirs for each mounted dir to avoid any collisions of files/dirs by same name. Adopt for older version of python3 How I did it Changes: Individual subdirs for each dir to be mounted subprocess args made compatible with older version of python3 (tested in version 3.5.3) How to verify it Simulate read-only state Run this script Test ssh via new tacacs user (who had not logged in earlier)
qiluo-msft
pushed a commit
that referenced
this pull request
Oct 27, 2021
What I did Have independent subdirs for each mounted dir to avoid any collisions of files/dirs by same name. Adopt for older version of python3 How I did it Changes: Individual subdirs for each dir to be mounted subprocess args made compatible with older version of python3 (tested in version 3.5.3) How to verify it Simulate read-only state Run this script Test ssh via new tacacs user (who had not logged in earlier)
4 tasks
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
Submodule update for sonic-utilties ``` 48035d7 [202012] [techsupport] Techsupport Error Reporting pending fixes (sonic-net#1854) 8b2ec09 Fix log_ssd_health hang issue (sonic-net#1904) ac9c425 Fix the option missing in kernel config issue (sonic-net#1888) 5cc9417 disk_check: Script updated to run good in 201811 & 201911 (sonic-net#1747) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Have independent subdirs for each mounted dir to avoid any collisions of files/dirs by same name.
Adopt for older version of python3
How I did it
Changes:
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)