[portconfig] Validate duplicate speed value and interface type value#1745
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Sep 14, 2021
Merged
[portconfig] Validate duplicate speed value and interface type value#1745qiluo-msft merged 2 commits intosonic-net:masterfrom
qiluo-msft merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1745 in repo Azure/sonic-utilities |
keboliu
previously approved these changes
Aug 16, 2021
liat-grozovik
approved these changes
Aug 17, 2021
Collaborator
|
@keboliu can you please signoff? |
keboliu
approved these changes
Sep 13, 2021
qiluo-msft
approved these changes
Sep 14, 2021
5 tasks
judyjoseph
pushed a commit
that referenced
this pull request
Sep 14, 2021
…1745) #### What I did Validate input parameter for command `config interface advertised-speeds` and `config interface advertised-types`, make sure there is no duplicate speeds or types #### How I did it Split input speeds/types with "," and check if there is a duplication, if yes, print an error. #### How to verify it 1. new unit test case 2. manual test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Validate input parameter for command
config interface advertised-speedsandconfig interface advertised-types, make sure there is no duplicate speeds or typesHow I did it
Split input speeds/types with "," and check if there is a duplication, if yes, print an error.
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)