[show] fix show muxcable metrics <port> for sorted output#1731
Merged
vdahiya12 merged 4 commits intosonic-net:masterfrom Jul 28, 2021
Merged
[show] fix show muxcable metrics <port> for sorted output#1731vdahiya12 merged 4 commits intosonic-net:masterfrom
vdahiya12 merged 4 commits intosonic-net:masterfrom
Conversation
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
tahmed-dev
previously approved these changes
Jul 28, 2021
tahmed-dev
approved these changes
Jul 28, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 29, 2021
This PR fixes the display for show muxcable metrics by sorting the output based on the time of the event. This is required for better display. For example admin@str2-7050cx3-acs-12:~$ show mux metrics Ethernet0 PORT EVENT TIME --------- --------------------------- --------------------------- Ethernet0 xcvrd_switch_standby_start 2021-Jul-21 02:03:28.784027 Ethernet0 orch_switch_standby_end 2021-Jul-21 02:03:28.788150 Ethernet0 linkmgrd_switch_standby_end 2021-Jul-21 02:03:28.790288 Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
This PR updates the following commits a9606fb [show] fix show muxcable metrics <port> for sorted output (sonic-net#1731) 7355016 [minigraph][port_config] Use imported config.main and add conditional patch (sonic-net#1728) cc1d6e4 [configlet] Python3 compatible syntax for extracting a key from the dict (sonic-net#1721) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
This PR fixes the display for show muxcable metrics by sorting the output based on the time of the event.
This is required for better display.
For example
admin@str2-7050cx3-acs-12:~$ show mux metrics Ethernet0PORT EVENT TIME--------- --------------------------- ---------------------------Ethernet0 xcvrd_switch_standby_start 2021-Jul-21 02:03:28.784027Ethernet0 orch_switch_standby_end 2021-Jul-21 02:03:28.788150Ethernet0 linkmgrd_switch_standby_end 2021-Jul-21 02:03:28.790288What I did
changed the output for muxcable metrics command for sorted time order
How I did it
made the changes inside the show/muxcable.py by sorting the output
How to verify it
unit-tests
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)