[debug dump util] Match Infrastructure by vivekrnv · Pull Request #1666 · sonic-net/sonic-utilities

vivekrnv · 2021-06-11T18:44:50Z

DEBUG DUMP UTIL PR SEQ: 1

What I did

HLD for Dump Utility: HLD.

Added the Logic for Match Infrastructure along with corresponding unit tests.

Note: Before merging other PR's, please merge this first

For More Info on MatchRequest and MatchEngine, Check this section in the HLD:
MatchInfra

How I did it

How to verify it

tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_bad_key_pattern PASSED [ 82%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_bad_request PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_invalid_combination PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_invalid_db PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_just_keys_return_fields_compat PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_no_file PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_no_source PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_no_table PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_no_value PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_return_fields_bad_format PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_vague_source PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_valid_match_request PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_field_value_match PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_field_value_match_list_type PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_field_value_no_match PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_file_source PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_file_source_with_key_ptrn PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_file_source_with_not_only_return_keys PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_for_no_key_match PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_for_no_match PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_just_keys_false PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_key_pattern_complex PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_key_pattern_wildcard PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_match_entire_list PASSED [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_return_fields_with_all_filtering PASSED [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_return_fields_with_field_value_filtering PASSED [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_return_fields_with_key_filtering PASSED [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_return_keys PASSED [ 85%]

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Vivek Reddy Karri <[email protected]>

into match_engine

Signed-off-by: Vivek Reddy Karri <[email protected]>

…o match_engine

SuvarnaMeenakshi

Please added unit test for namespace DBs as well.

dump/match_infra.py

tests/dump_tests/match_engine_test.py

vivekrnv · 2021-06-22T22:57:51Z

Please added unit test for namespace DBs as well.

Added the Test

Signed-off-by: Vivek Reddy Karri <[email protected]>

…o match_engine

Signed-off-by: Vivek Reddy Karri <[email protected]>

liat-grozovik · 2021-06-29T20:16:25Z

@SuvarnaMeenakshi could you please review following unit test added?

SuvarnaMeenakshi

LGTM

vivekrnv · 2021-07-20T18:51:49Z

Request for 202106

What I did HLD for Dump Utility: HLD. Added the Logic for Match Infrastructure along with corresponding unit tests. Note: Before merging other PR's, please merge this first For More Info on MatchRequest and MatchEngine, Check this section in the HLD: MatchInfra

What I did Implemented vlan and vlan_member modules for debug dump utility. How I did it Used infrastructure and followed examples in #1666 #1667 #1668 #1669 #1670 How to verify it On switch: dump state vlan <vlan_name> dump state vlan_member '<vlan_name|<member_name>' Unit test: pytest-3 dump_tests/module_tests/vlan_test.py (same test file covers both vlan and vlan_member)

vivekrnv added 14 commits May 14, 2021 05:02

Match Infra Added

5bec449

Signed-off-by: Vivek Reddy Karri <[email protected]>

Missing file added

4da400b

Signed-off-by: Vivek Reddy Karri <[email protected]>

Multi-Asic Changes Made

6c8667a

Signed-off-by: Vivek Reddy Karri <[email protected]>

Minor Changes

42118c0

Signed-off-by: Vivek Reddy Karri <[email protected]>

Minor Fixes

f83317a

Signed-off-by: Vivek Reddy Karri <[email protected]>

Merge branch 'master' of https://github.com/vivekreddynv/sonic-utilities

724d584

into match_engine

Name Change and match_list changes made

c9dcfef

Signed-off-by: Vivek Reddy Karri <[email protected]>

Minor Typo

bd47df0

Signed-off-by: Vivek Reddy Karri <[email protected]>

Final Changes before review made

b8da286

Signed-off-by: Vivek Reddy Karri <[email protected]>

Comments addressed

8cd32cd

Signed-off-by: Vivek Reddy Karri <[email protected]>

Comments addressed

6da04b4

Signed-off-by: Vivek Reddy Karri <[email protected]>

pylint issues dealt with

1a08fe8

Signed-off-by: Vivek Reddy Karri <[email protected]>

Minor Fixes

3859648

Signed-off-by: Vivek Reddy Karri <[email protected]>

Moved the mock files dir

2c73a59

Signed-off-by: Vivek Reddy Karri <[email protected]>

This was referenced Jun 11, 2021

[debug dump util] Module implementation Logic and Port Module #1667

Merged

Debug dump utility HLD sonic-net/SONiC#789

Merged

liat-grozovik requested a review from SuvarnaMeenakshi June 16, 2021 16:38

Merge branch 'master' of https://github.com/Azure/sonic-utilities int…

5b2af1b

…o match_engine

SuvarnaMeenakshi requested changes Jun 22, 2021

View reviewed changes

vivekrnv added 5 commits June 22, 2021 23:12

Namespace changes updated

30528b4

Signed-off-by: Vivek Reddy Karri <[email protected]>

Multi-Asic Changes Made

7eded22

Signed-off-by: Vivek Reddy Karri <[email protected]>

Minor Changes

0a4765d

Signed-off-by: Vivek Reddy Karri <[email protected]>

Merge branch 'master' of https://github.com/Azure/sonic-utilities int…

0b07a99

…o match_engine

moved from utilities common to sonic_py_common

0cdc865

Signed-off-by: Vivek Reddy Karri <[email protected]>

SuvarnaMeenakshi approved these changes Jul 7, 2021

View reviewed changes

liat-grozovik approved these changes Jul 7, 2021

View reviewed changes

SuvarnaMeenakshi merged commit 9ae6f6b into sonic-net:master Jul 14, 2021

liat-grozovik added the Request for 202106 Branch label Jul 25, 2021

judyjoseph added the Included in 202106 Branch label Aug 26, 2021

raphaelt-nvidia mentioned this pull request Oct 13, 2021

[debug dump util] Vlan Module Added #1877

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[debug dump util] Match Infrastructure#1666

[debug dump util] Match Infrastructure#1666
SuvarnaMeenakshi merged 20 commits intosonic-net:masterfrom
vivekrnv:match_engine

vivekrnv commented Jun 11, 2021 •

edited

Loading

Uh oh!

SuvarnaMeenakshi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vivekrnv commented Jun 22, 2021 •

edited

Loading

Uh oh!

liat-grozovik commented Jun 29, 2021

Uh oh!

SuvarnaMeenakshi left a comment

Uh oh!

vivekrnv commented Jul 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

vivekrnv commented Jun 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

SuvarnaMeenakshi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vivekrnv commented Jun 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liat-grozovik commented Jun 29, 2021

Uh oh!

SuvarnaMeenakshi left a comment

Choose a reason for hiding this comment

Uh oh!

vivekrnv commented Jul 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vivekrnv commented Jun 11, 2021 •

edited

Loading

vivekrnv commented Jun 22, 2021 •

edited

Loading