[201911][db_migrator] fix old 1911 feature config migration to a new schema#1655
Merged
abdosi merged 7 commits intosonic-net:201911from Jun 18, 2021
Merged
[201911][db_migrator] fix old 1911 feature config migration to a new schema#1655abdosi merged 7 commits intosonic-net:201911from
abdosi merged 7 commits intosonic-net:201911from
Conversation
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
liat-grozovik
approved these changes
Jun 7, 2021
Collaborator
|
Don't merge yet. Pending offline tests since Jenkins cheekers are not running. |
qiluo-msft
approved these changes
Jun 7, 2021
stepanblyschak
changed the title
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
stepanblyschak
force-pushed
the
fix-1911-db-mig
branch
from
67272ea to
24d9278
Compare
Collaborator
|
Approved from Mellanox side. This fixes the problem seen with the prev update. |
Contributor
|
please add unit-test as part of this pr. |
Contributor
|
I have reverted the PR. Please update again in this PR with unit-test Revert "[201911][db_migrator] fix old 1911 feature config migration to |
yxieca
reviewed
Jun 7, 2021
stepanblyschak
changed the title
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Collaborator
yxieca
approved these changes
Jun 17, 2021
stepanblyschak
added a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
[201911][db_migrator] fix old 1911 feature config migration to a new schema (sonic-net#1655) Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak stepanb@nvidia.com
What I did
Fixed badly converted code change from master for 201911in #1637.
This PR fixes python3.5 feature usage.
How I did it
Used python2 approach.
How to verify it
Takes this script and run on switch: db_migrator.py -o migrate.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)