Add 'default' option for sFlow.#1606
Merged
prsunny merged 2 commits intosonic-net:masterfrom May 12, 2021
Merged
Conversation
Signed-off-by: Venkatesan Mahalingam <[email protected]>
Contributor
|
Could you please add a unit test for |
Signed-off-by: Venkatesan Mahalingam <[email protected]>
Contributor
Author
Done, please review the PR and merge if changes look good. |
prsunny
approved these changes
May 12, 2021
gitsabari
pushed a commit
to gitsabari/sonic-utilities
that referenced
this pull request
Jun 15, 2021
* Add 'default' option for sFlow. Signed-off-by: Venkatesan Mahalingam <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
901e2efb4f5c6a1179068b43e6a837dfff19d9d9 (HEAD -> 201911, origin/201911) [fpmsyncd] Skip routes to eth0 or docker0 (sonic-net#1606) 6c6f4fbbeb24b6e16a2bffdee760ba6a95e2ceb3 configure extra inc/lib directory for build (sonic-net#1247) cccb59efa031b817c1936a74db969debbb9b2775 [201911][Cherry-pick] [acl mirror action] Mirror session ref count fix at acl rule attachment (sonic-net#1896) 62dc36d9da988807c7a397fd90ac2859a5a07699 [ci]: Support Azure pipelines on 201911 branch (sonic-net#1806) Signed-off-by: Abhishek Dosi <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
ea9c6690cafb959d28c90fd5d01fce5bbb5f899b (HEAD -> 201911, origin/201911) Revert "[fpmsyncd] Skip routes to eth0 or docker0 (sonic-net#1606)" Signed-off-by: Abhishek Dosi <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
[fpmsyncd] Skip routes to eth0 or docker0 (sonic-net#1606) Signed-off-by: Abhishek Dosi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Venkatesan Mahalingam [email protected]
The changes are copied from #845 to resolve the conflict.
The dependent swss PR : sonic-net/sonic-swss#1728
Adding the 'default' option to allow user to set an interface's
sFlow sampling-rate back to default.
What I did
Add a 'default' option so users can revert to the default sFlow sampling-rate on an interface.
How I did it
Updated the config script in config/main.py.
How to verify it
Unit-test: