Skip to content

[console] Include Flow Control status in show line result#1549

Merged
Blueve merged 1 commit intosonic-net:masterfrom
Blueve:dev/jika/flowcontrol
Apr 7, 2021
Merged

[console] Include Flow Control status in show line result#1549
Blueve merged 1 commit intosonic-net:masterfrom
Blueve:dev/jika/flowcontrol

Conversation

@Blueve
Copy link
Copy Markdown
Contributor

@Blueve Blueve commented Apr 6, 2021

What I did

Include flow control status in show line result.

How I did it

  1. Render the flow control option in show line table
  2. Update unit test case
  3. Update document

How to verify it

  1. UT pass
  2. Install and test the new package in a physical SONiC box

Previous command output (if the output of a command-line utility has changed)

admin@sonic:~$ show line
  Line    Baud    PID    Start Time    Device
------  ------  -----  ------------  --------
     1    9600      -             -
     2       -      -             -
     3       -      -             -
     4       -      -             -
     5       -      -             -

New command output (if the output of a command-line utility has changed)

admin@sonic:~$ show line
  Line    Baud    Flow Control    PID    Start Time    Device
------  ------  --------------  -----  ------------  --------
     1    9600         Enabled      -             -
     2       -        Disabled      -             -
     3       -        Disabled      -             -
     4       -        Disabled      -             -
     5       -        Disabled      -             -

@Blueve Blueve requested a review from yxieca April 6, 2021 07:02
@Blueve Blueve merged commit 5976399 into sonic-net:master Apr 7, 2021
@Blueve Blueve deleted the dev/jika/flowcontrol branch April 7, 2021 02:16
gitsabari pushed a commit to gitsabari/sonic-utilities that referenced this pull request Jun 15, 2021
…1549)

- Render the flow control option in show line table
- Update unit test case
- Update document

Signed-off-by: Jing Kan jika@microsoft.com
qiluo-msft pushed a commit that referenced this pull request Aug 3, 2021
- Render the flow control option in show line table
- Update unit test case
- Update document

Signed-off-by: Jing Kan jika@microsoft.com
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
To include following changes:

* d84a8cc 2021-08-05 | [fast-reboot] revert the change of disabling counter polling before fast-reboot (sonic-net#1744) (HEAD -> 202012, github/202012) [Ying Xie]
* e900bc5 2021-08-04 | Add script null_route_helper (sonic-net#1718) [bingwang-ms]
* 85f14e1 2021-08-02 | disk_check updates: (sonic-net#1736) [Renuka Manavalan]
* d68ac1c 2021-05-27 | [console][show] Force refresh all lines status during show line (sonic-net#1641) [Blueve]
* a0e417f 2021-04-25 | [console] Display success message after line cleared (sonic-net#1579) [Blueve]
* 0c6bb27 2021-04-07 | [console] Include Flow Control status in show line result (sonic-net#1549) [Blueve]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants