[sonic-package-manager] first phase implementation of sonic-package-manager by stepanblyschak · Pull Request #1527 · sonic-net/sonic-utilities

stepanblyschak · 2021-03-25T11:37:35Z

What I did

Implemented sonic-package-manager utility to manager SONiC Packages as per HLD sonic-net/SONiC#682.
Implemented optional logic to migrate packages into new SONiC image in sonic-installer.

How I did it

Implemented as per HLD sonic-net/SONiC#682.

How to verify it

(Doc: sonic-net/SONiC#682)

install package
uninstall package
upgrade package
S2S upgrade

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

…packages-migration

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

…packages-migration Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

lgtm-com · 2021-03-25T11:46:56Z

This pull request introduces 2 alerts when merging f2ee39f into 1ee04fb - view on LGTM.com

new alerts:

2 for Unused import

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

lgtm-com · 2021-03-25T13:29:02Z

This pull request introduces 2 alerts when merging c724569 into 1ee04fb - view on LGTM.com

new alerts:

2 for Unused import

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

lgtm-com · 2021-03-25T14:16:48Z

This pull request introduces 2 alerts when merging 3dc793f into 1ee04fb - view on LGTM.com

new alerts:

2 for Unused import

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

lgtm-com · 2021-03-25T15:31:06Z

This pull request introduces 2 alerts when merging faeadcf into 1ee04fb - view on LGTM.com

new alerts:

2 for Unused import

renukamanavalan

Rest of the review can be done during sub group meeting, with Stephan leading it.

doc/Command-Reference.md

Co-authored-by: Joe LeVeque <jleveque@users.noreply.github.com>

lgtm-com · 2021-03-29T07:31:37Z

This pull request introduces 2 alerts when merging ae1ce45 into 28b64ec - view on LGTM.com

new alerts:

2 for Unused import

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

Co-authored-by: Jan Klare <janklare@gmail.com>

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

doc/Command-Reference.md

sonic_installer/main.py

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

stepanblyschak · 2021-04-28T10:01:13Z

How are the docker image tags going to be used here? Maybe they should be shown instead or additionally to the "Version" ?
[SB] They are not displayed here, user can do "docker images" to see the tag

liat-grozovik · 2021-04-28T10:14:10Z

@renukamanavalan do we still have open issues following all the above fixes?

setup.py

sonic_installer/bootloader/bootloader.py

sonic_package_manager/manager.py

sonic_package_manager/manifest.py

sonic_package_manager/registry.py

tests/sonic_package_manager/test_constraint.py

tests/sonic_package_manager/test_manager.py

tests/sonic_package_manager/test_metadata.py

tests/sonic_package_manager/test_reference.py

tests/sonic_package_manager/test_service_creator.py

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

jleveque

Looks good to me. This is a large PR but the code is very clean, well-organized and easy to read. Thank you!

renukamanavalan · 2021-04-28T22:14:33Z

Ready for merge. Waiting for build to complete.

…anager (sonic-net#1527) What I did Implemented sonic-package-manager utility to manager SONiC Packages as per HLD sonic-net/SONiC#682. Implemented optional logic to migrate packages into new SONiC image in sonic-installer. How I did it Implemented as per HLD sonic-net/SONiC#682. How to verify it (Doc: sonic-net/SONiC#682) install package uninstall package upgrade package S2S upgrade THANK YOU, Stepan!

stepanblyschak added 14 commits November 3, 2020 15:56

[sonic-installer] migrate SONiC packages

2356869

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

fix temp dir path for chroot

ece3845

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

fix for install of already installed image

8bc75a7

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

move constants to the top

e72f540

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

Merge branch 'master' of github.com:azure/sonic-utilities into sonic-…

1a6d5d9

…packages-migration

[sonic_installer] migrate packages from old docker library

be4f089

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

Merge branch 'master' of github.com:azure/sonic-utilities into sonic-…

2240308

…packages-migration Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

remove unused imports

9fd283d

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

fix redefining path

0cbaa3e

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

[sonic-package-manager] add new utility to manage SONiC packages

1a99797

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

Merge branch 'sonic-packages-migration' into spm

a80ecb0

add help for some options

06dfd30

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

add command line reference for sonic-package-manager

725210d

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

fix upgrade command missing argument

f2ee39f

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

This was referenced Mar 25, 2021

[sonic-package-manager] first phase implementation of sonic-package-manager sonic-net/sonic-buildimage#6076

Closed

[sonic-installer] migrate SONiC packages #1336

Closed

iteritems -> items

c724569

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

fix issue in metadata dict generation

3dc793f

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

default value for component constraint

faeadcf

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

renukamanavalan reviewed Mar 25, 2021

View reviewed changes

stepanblyschak mentioned this pull request Mar 26, 2021

SONiC Application Extension PR Tracker sonic-net/sonic-buildimage#6398

Open

jleveque suggested changes Mar 26, 2021

View reviewed changes

doc/Command-Reference.md Outdated Show resolved Hide resolved

Update doc/Command-Reference.md

ae1ce45

Co-authored-by: Joe LeVeque <jleveque@users.noreply.github.com>

stepanblyschak added 2 commits April 1, 2021 16:33

drop support for monit as monit is getting deprecated

83f2af6

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

fix manifest representation

d31497a

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

stepanblyschak and others added 10 commits April 21, 2021 03:59

Update doc/Command-Reference.md

ae5bad9

Co-authored-by: Jan Klare <janklare@gmail.com>

Update doc/Command-Reference.md

909079a

Co-authored-by: Jan Klare <janklare@gmail.com>

Update doc/Command-Reference.md

a394b27

Co-authored-by: Jan Klare <janklare@gmail.com>

Update doc/Command-Reference.md

9653c61

Co-authored-by: Jan Klare <janklare@gmail.com>

Update doc/Command-Reference.md

0e96ddb

Co-authored-by: Jan Klare <janklare@gmail.com>

Update doc/Command-Reference.md

9090a47

Co-authored-by: Jan Klare <janklare@gmail.com>

Update doc/Command-Reference.md

b2eeb59

Co-authored-by: Jan Klare <janklare@gmail.com>

review comments

e765d5d

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

Merge branch 'spm' of github.com:stepanblyschak/sonic-utilities into spm

24fb439

fix upgrade rollback

fd46c34

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

renukamanavalan reviewed Apr 22, 2021

View reviewed changes

stepanblyschak added 3 commits April 23, 2021 14:29

address review comments

86bf53f

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

fix command line options for install/upgrade

1ace0e1

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

fix bug when have components constraints

6feda36

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

stepanblyschak force-pushed the spm branch from 0fc6463 to 6feda36 Compare April 26, 2021 14:16

Merge branch 'master' into spm

a2f7649

renukamanavalan previously approved these changes Apr 28, 2021

View reviewed changes

renukamanavalan requested a review from jleveque April 28, 2021 17:14

jleveque suggested changes Apr 28, 2021

View reviewed changes

stepanblyschak added 2 commits April 29, 2021 00:30

Fix review comments

0d5dfcf

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

Merge branch 'spm' of github.com:stepanblyschak/sonic-utilities into spm

4c2f986

stepanblyschak dismissed renukamanavalan’s stale review via 4c2f986 April 28, 2021 21:33

jleveque approved these changes Apr 28, 2021

View reviewed changes

renukamanavalan merged commit 08337aa into sonic-net:master Apr 29, 2021

sujinmkang mentioned this pull request May 5, 2021

sonic image downgrade failure from latest public master image sonic-net/sonic-buildimage#7518

Closed

yxieca mentioned this pull request May 9, 2021

Arista platform installation failure sonic-net/sonic-buildimage#7566

Closed

Conversation

stepanblyschak commented Mar 25, 2021

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

lgtm-com bot commented Mar 25, 2021

Uh oh!

lgtm-com bot commented Mar 25, 2021

Uh oh!

lgtm-com bot commented Mar 25, 2021

Uh oh!

lgtm-com bot commented Mar 25, 2021

Uh oh!

renukamanavalan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented Mar 29, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stepanblyschak commented Apr 28, 2021

Uh oh!

liat-grozovik commented Apr 28, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jleveque left a comment

Choose a reason for hiding this comment

Uh oh!

renukamanavalan commented Apr 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants