Handling error scenario of adding port to Vlan which is part of LAG#1516
Merged
prsunny merged 2 commits intosonic-net:masterfrom Mar 23, 2021
Merged
Handling error scenario of adding port to Vlan which is part of LAG#1516prsunny merged 2 commits intosonic-net:masterfrom
prsunny merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Sudharsan Dhamal Gopalarathnam <[email protected]> Handled error scenario when adding a port to Vlan which is already part of a LAG Fixed the config vlan script to check if port is a port channel member before setting config_db config vlan add 10 config portchannel add PortChannel0 config portchannel member add PortChannel0 Ethernet0 config vlan member add 10 Ethernet0 Usage: config vlan member add [OPTIONS] <vid> port Try "config vlan member add -h" for help. Error: Ethernet0 is part of portchannel!
Collaborator
Author
|
Please backport it to 202012 and other required releases. |
dgsudharsan
changed the title
dgsudharsan
changed the title
Collaborator
Author
|
retest vs please |
Collaborator
Author
|
retest this please |
1 similar comment
Collaborator
Author
|
retest this please |
prsunny
approved these changes
Mar 23, 2021
yxieca
pushed a commit
that referenced
this pull request
Mar 26, 2021
…1516) *Handled error scenario when adding a port to Vlan which is already part of a LAG. Added unit test to cover the scenario. This is fix for the bug sonic-net/sonic-buildimage#4456 Signed-off-by: Sudharsan Dhamal Gopalarathnam <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
756dd9c8123cd06dc581d9b2eb236334deee1850 (HEAD -> 201911, origin/201911) [201911 sonic-swss] Flushing FDB entries before removing BridgePort (sonic-net#1516) e3f22ea6685104a819440ecc0efe89c4bd3a0003 [201911/portsorch] Add correct stat list for port buffer drop counters (sonic-net#1509) Signed-off-by: Abhishek Dosi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Handled error scenario when adding a port to Vlan which is already part of a LAG. Added unit test to cover the scenario. This is fix for the bug sonic-net/sonic-buildimage#4456
How I did it
Fixed the config vlan script to check if port is a port channel member before setting config_db
How to verify it
config vlan add 10
config portchannel add PortChannel0
config portchannel member add PortChannel0 Ethernet0
config vlan member add 10 Ethernet0
Usage: config vlan member add [OPTIONS] port
Try "config vlan member add -h" for help.
Error: Ethernet0 is part of portchannel!
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)