[test] Update unit test coverage for command 'show mac'#1504
Merged
gechiang merged 1 commit intosonic-net:masterfrom Mar 18, 2021
Merged
[test] Update unit test coverage for command 'show mac'#1504gechiang merged 1 commit intosonic-net:masterfrom
gechiang merged 1 commit intosonic-net:masterfrom
Conversation
ghost
marked this pull request as ready for review
Author
|
This pull request introduces 1 alert when merging 6f70d0df650b4b593af6a8b12681272a534f5950 into 0de99c3 - view on LGTM.com new alerts:
|
Contributor
|
@maksymbelei95 testcases looks good. According to the test report it shows following: |
* Adding unit tests for CLI command 'show mac'. Testing both CLI command and 'fdbshow' script. Signed-off-by: Maksym Belei <[email protected]>
Author
|
@gechiang, I have updated unit tests and made some refactoring in fdshow script. Could you check the updates? Currently, fdbshow has covered by 100%. |
gechiang
approved these changes
Mar 18, 2021
Contributor
|
Nice work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
both CLI command and 'fdbshow' script.
Signed-off-by: Maksym Belei [email protected]
What I did
Unit test coverage has updated for CLI command
show mac. The PR includes test case for #1368.How I did it
Added new unit tests for command
show mac. Tested both CLI command andfdbshowscript directly.How to verify it
See unit test coverage report.