Skip to content

FRR: fix show bgp and clear bgp to provide the full set of cli options available#149

Merged
lguohan merged 6 commits intosonic-net:masterfrom
nikos-github:fix
Nov 23, 2017
Merged

FRR: fix show bgp and clear bgp to provide the full set of cli options available#149
lguohan merged 6 commits intosonic-net:masterfrom
nikos-github:fix

Conversation

@nikos-github
Copy link
Contributor

No description provided.

clear/main.py Outdated
# Inserting BGP functionality into cli's clear parse-chain. The insertion point
# and the specific BGP commands to import, will be determined by the routing-stack
# being elected.
# Inserting BGP functionality into cli's show parse-chain.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do s/show/clear.

@cli.command()
@click.argument('bgp_args', nargs = -1, required = False)
def bgp(bgp_args):
bgp_cmd = "show bgp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a command description for both "show bgp" and "clear bgp".

We had this before for clear: """Clear BGP peers / state""" and something similar for show.

@lguohan lguohan merged commit cbd956d into sonic-net:master Nov 23, 2017
@nikos-github nikos-github deleted the fix branch November 23, 2017 01:01
vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this pull request Jul 23, 2021
Configure Azure Pipelines to run unit tests on all packages, build all Python wheels and publish the test results, test coverage and resulting wheels.

Note: Azure Pipelines currently has a limitation such that it does not properly support publishing multiple test coverage reports in the same pipeline. If you publish multiple test coverage reports in the same pipeline (which I am doing here), the summary and report is shown for the last task only. Any previously uploaded data is ignored. Hopefully Azure Pipelines will add support for multiple test coverage reports in the near future. See [here](https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/test/publish-code-coverage-results?view=azure-devops#is-code-coverage-data-merged-when-multiple-files-are-provided-as-input-to-the-task-or-multiple-tasks-are-used-in-the-pipeline) for more info.
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
Close EEPROM lock file after unlocking. Python 3 now outputs warnings such as the following to stderr if a file descriptor is left open:

```
/usr/local/bin/decode-syseeprom:171 : ResourceWarning : unclosed file <_io.TextIOWrapper name='/var/run/hw-management/eeprom/vpd_info' mode='r' encoding='UTF-8'>
```

With this change, the above warning is no longer displayed.
Junchao-Mellanox pushed a commit to Junchao-Mellanox/sonic-utilities that referenced this pull request Mar 31, 2025
sonic-net#149)

```<br>* 8af724a1 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-utilities into 202412 (2025-03-11) [Sonic Automation]
* 7a3f4ad - (origin/202411) Fix the interface name length validation for subinterface (sonic-net#3799) (2025-03-11) [mssonicbld]
* 357f95d - enable pfcwd for backplane ports (sonic-net#3796) (2025-03-07) [mssonicbld]
* 7f316e7 - revert YANG check in db_migrator (sonic-net#3794) (2025-03-06) [mssonicbld]
* c01a4f5 - Add namespace support for show interface neighbor expected (sonic-net#3790) (2025-03-03) [mssonicbld]
* 17a7b18 - Fix `vnet_route_check` for active and inactive routes, add `--all` option (sonic-net#3780) (2025-02-25) [mssonicbld]
* 5cc1012 - [202411][FC] remove FC delay field (sonic-net#3768) (2025-02-21) [Stepan Blyshchak]
* 8ceba38 - [QOS] Skip showing unnecessary warning message (sonic-net#3762) (2025-02-11) [mssonicbld]
* 04b60e2 - Fix call for spanning-tree commands in dump script (sonic-net#3752) (2025-02-07) [mssonicbld]
* bbe29ae - [show][interface] Add changes for show interface errors command (sonic-net#3749) (2025-02-04) [mssonicbld]<br>```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants