Skip to content

[pfcwd]: Configuration commands#147

Merged
lguohan merged 1 commit intosonic-net:masterfrom
marian-pritsak:pfcwd-conf
Nov 9, 2017
Merged

[pfcwd]: Configuration commands#147
lguohan merged 1 commit intosonic-net:masterfrom
marian-pritsak:pfcwd-conf

Conversation

@marian-pritsak
Copy link
Collaborator

Add 'start/stop' commands
Create 'show' group
Move 'stats' to 'show' and add 'show config'

Signed-off-by: marian-pritsak marianp@mellanox.com

Add 'start/stop' commands
Create 'show' group
Move 'stats' to 'show' and add 'show config'

Signed-off-by: marian-pritsak <marianp@mellanox.com>
@marian-pritsak
Copy link
Collaborator Author

marian-pritsak commented Nov 8, 2017

Depends on: sonic-net/sonic-swss#374

@lguohan lguohan merged commit e87bb97 into sonic-net:master Nov 9, 2017
vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this pull request Jul 23, 2021
…t test coverage (sonic-net#147)

- Refactor ledd to allow for more thorough unit testing
    - Remove infinite loop from `run()` method to allow unit testing of the method. Instead, call the `run()` method in an infinite loop in `main()`
- Increase overall ledd unit test coverage from 48% to 93%.

Previous unit test coverage:

```
----------- coverage: platform linux, python 3.7.3-final-0 -----------
Name           Stmts   Miss  Cover
----------------------------------
scripts/ledd      66     34    48%
Coverage HTML written to dir htmlcov
Coverage XML written to file coverage.xml
```

Unit test coverage with this patch:

```
----------- coverage: platform linux, python 3.7.3-final-0 -----------
Name           Stmts   Miss  Cover
----------------------------------
scripts/ledd      72      5    93%
Coverage HTML written to dir htmlcov
Coverage XML written to file coverage.xml
```
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
This PR provides the support for error checking the returned values from eeprom read for sonic_y_cable, particularly if garbage/non expected value/values are returned.
What is the motivation for this PR?
support for error checking the returned values from eeprom read for sonic_y_cable, particularly if garbage/non expected values are returned.
How did you do it?
added code after read_eeprom api's to validate the returned values.
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Junchao-Mellanox pushed a commit to Junchao-Mellanox/sonic-utilities that referenced this pull request Mar 31, 2025
sonic-net#147)

```<br>* f8a5fd39 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-utilities into 202412 (2025-03-09) [Sonic Automation]
* 357f95d - (origin/202411) enable pfcwd for backplane ports (sonic-net#3796) (2025-03-07) [mssonicbld]
* 7f316e7 - revert YANG check in db_migrator (sonic-net#3794) (2025-03-06) [mssonicbld]
* c01a4f5 - Add namespace support for show interface neighbor expected (sonic-net#3790) (2025-03-03) [mssonicbld]
* 17a7b18 - Fix `vnet_route_check` for active and inactive routes, add `--all` option (sonic-net#3780) (2025-02-25) [mssonicbld]
* 5cc1012 - [202411][FC] remove FC delay field (sonic-net#3768) (2025-02-21) [Stepan Blyshchak]
* 8ceba38 - [QOS] Skip showing unnecessary warning message (sonic-net#3762) (2025-02-11) [mssonicbld]
* 04b60e2 - Fix call for spanning-tree commands in dump script (sonic-net#3752) (2025-02-07) [mssonicbld]
* bbe29ae - [show][interface] Add changes for show interface errors command (sonic-net#3749) (2025-02-04) [mssonicbld]<br>```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants