[sfpshow] Cleanup#1405
Merged
jleveque merged 7 commits intosonic-net:masterfrom Feb 18, 2021
jleveque:sfpshow_cleanup
Merged
Conversation
lguohan
approved these changes
Feb 18, 2021
4 tasks
yxieca
pushed a commit
that referenced
this pull request
Feb 23, 2021
Clean up sfpshow utility - Reword header docstring and comments - Unify formatting - Rename variables and constants - Use `+=` for string concatenation to reduce line length - Pass through `autopep8 --max-line-length 120`
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
Clean up sfpshow utility - Reword header docstring and comments - Unify formatting - Rename variables and constants - Use `+=` for string concatenation to reduce line length - Pass through `autopep8 --max-line-length 120`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Clean up sfpshow utility
- How I did it
+=for string concatenation to reduce line lengthautopep8 --max-line-length 120