Skip to content

[ecnconfig] Allow ecn unit test to run without sudo #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiluo-msft merged 2 commits into from
Jan 29, 2021
Merged

[ecnconfig] Allow ecn unit test to run without sudo #1390

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e134f1
Allow ecn unit test to run without sudo
neethajohn Jan 29, 2021
6f6c1dc
Address review comments
neethajohn Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/ecnconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ class EcnConfig(object):
return result

def set_wred_threshold(self, profile, threshold, value):
if os.geteuid() != 0:
if os.geteuid() != 0 and os.environ.get("UTILITIES_UNIT_TESTING", "0") != "2":
Copy link
Copy Markdown
Contributor

@qiluo-msft qiluo-msft Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract lines into a function?

        if os.geteuid() != 0 and os.environ.get("UTILITIES_UNIT_TESTING", "0") != "2":
            sys.exit("Root privileges required for this operation")

Copy link
Copy Markdown
Contributor Author

@neethajohn neethajohn Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

sys.exit("Root privileges required for this operation")

field = WRED_CONFIG_FIELDS[threshold]
Expand All @@ -179,7 +179,7 @@ class EcnConfig(object):
json.dump(prof_table, fd)

def set_wred_prob(self, profile, drop_color, value):
if os.geteuid() != 0:
if os.geteuid() != 0 and os.environ.get("UTILITIES_UNIT_TESTING", "0") != "2":
sys.exit("Root privileges required for this operation")

field = WRED_CONFIG_FIELDS[drop_color]
Expand Down Expand Up @@ -227,7 +227,7 @@ class EcnQ(object):
)

def set(self, enable):
if os.geteuid() != 0:
if os.geteuid() != 0 and os.environ.get("UTILITIES_UNIT_TESTING", "0") != "2":
sys.exit("Root privileges required for this operation")
for queue in self.queues:
if self.verbose:
Expand Down