[ecn] Add tests for ecnconfig command#1372
Merged
neethajohn merged 4 commits intosonic-net:masterfrom Jan 21, 2021
Merged
Conversation
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
|
This pull request introduces 1 alert when merging d17fb1e into 8119ba2 - view on LGTM.com new alerts:
|
lguohan
approved these changes
Jan 20, 2021
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
- What I did Added unit tests for ecnconfig command Updated 'show ecn' command to use run_command wrapper Updated 'config ecn' command to allow configuration of drop probabilities Cleanup trailing spaces in ecnconfig script and add hooks to support unit tests - How to verify it Ran the new ecn_test.py and it passed Signed-off-by: Neetha John <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
[portsorch] add buffer drop FC group [bitmap_vnet] Fix VNET route priority issue (sonic-net#1421) [vnet] Maintain the reference count of the nexthop when creating a vn… (sonic-net#1414) [intfsorch] Retrieve Port object before setting NAT zone on router interfaces. (sonic-net#1372)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Added unit tests for ecnconfig command
Updated 'show ecn' command to use run_command wrapper
Updated 'config ecn' command to allow configuration of drop probabilities
Cleanup trailing spaces in ecnconfig script and add hooks to support unit tests
- How to verify it
Ran the new ecn_test.py and it passed