[unit test][pfcwd] Fix tests that require sudo access#1340
Merged
smaheshm merged 2 commits intosonic-net:masterfrom Dec 29, 2020
Merged
[unit test][pfcwd] Fix tests that require sudo access#1340smaheshm merged 2 commits intosonic-net:masterfrom
smaheshm merged 2 commits intosonic-net:masterfrom
Conversation
lguohan
previously approved these changes
Dec 28, 2020
jleveque
suggested changes
Dec 28, 2020
tests/pfcwd_test.py
Outdated
| import sys | ||
|
|
||
| from click.testing import CliRunner | ||
| from unittest.mock import patch |
Contributor
There was a problem hiding this comment.
unittest is part of the standard library. Please move this line to the bottom of the first group of imports, e.g.,
import imp
import os
import sys
from unittest.mock import patch
jleveque
approved these changes
Dec 28, 2020
gechiang
approved these changes
Dec 28, 2020
Contributor
Author
|
retest this please |
1 similar comment
Contributor
Author
|
retest this please |
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
* mock os.geteuid * rearrange imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
The 'config' tests that require sudo access were failing. Fixed it by mocking os.geteuid.
- How I did it
Fixed it my mocking os.geteuid.
- How to verify it
Unit tests and manual verification
samaddik@856d790db1d1:/sonic/src/sonic-utilities/tests$ pytest-3 pfcwd_test.py -k test_pfcwd_start_actions_masic
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)