Fix show ip/v6 route summary non-multi-asic platform to interact with…#1306
Merged
abdosi merged 1 commit intosonic-net:201911from Dec 15, 2020
gechiang:201911
Merged
Fix show ip/v6 route summary non-multi-asic platform to interact with…#1306abdosi merged 1 commit intosonic-net:201911from gechiang:201911
abdosi merged 1 commit intosonic-net:201911from
gechiang:201911
Conversation
smaheshm
reviewed
Dec 14, 2020
| # Due to options such as "summary" and "tables" are not yet supported in multi-asic platform | ||
| # we will let FRR handle all the processing instead of handling it here for non multi-asic platform | ||
| if multi_asic.is_multi_asic(): | ||
| if found_tables: |
Contributor
There was a problem hiding this comment.
how are you checking for "summary" option there?
Contributor
Author
There was a problem hiding this comment.
For Non-multi-asic platform the parameter checking is all done by BGP itself.
For Multi-ASIC platform it currently will fail due to the added "json" parm was requested to BGP and BGP will fail the request. So there is no need to specifically check for this for now.
I will be adding the support for the Multi-ASIC platform for the "summary" option which at that time it will be inspected and handled accordingly. Not part of this PR though...
abdosi
approved these changes
Dec 15, 2020
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
b909766aab63da5e9a51e05fd2bf79e80db75e5 (HEAD -> 201911, origin/201911) Fix show ip/v6 route summary non-multi-asic platform to interact with FRR directly (sonic-net#1306) 057d2ee Add support to collect tech support on multi ASIC platform (sonic-net#1308) 38ab16d [CLI][PFCWD] Fix issue with specifying ports in pfcwd start on masic platforms (sonic-net#1203) Signed-off-by: Abhishek Dosi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How to verify it
Perform "show ip/v6 route summary" and many other options to ensure that both pizzabox and multi-asic platforms are handling them correctly.
Before the fix:
After the fix:
This PR is created to port the same change of the master branch to 201911 branch for PR:
#1302