[portstat]: Combine ADMIN and OPER fields#130
Merged
stcheng merged 1 commit intosonic-net:masterfrom Oct 17, 2017
Merged
Conversation
Contributor
Author
|
jleveque
approved these changes
Oct 16, 2017
taoyl-ms
reviewed
Oct 16, 2017
scripts/portstat
Outdated
Contributor
There was a problem hiding this comment.
This does not match the output format in previous versions. Do we want to make it consistent?
Contributor
Author
There was a problem hiding this comment.
i've updated this pull request. please check.
- Move back to one column of port state to be compatible with old parsers - The current state field has four choices: U, D, X, and N/A. U means the port is admin + oper status UP D means the port is admin UP but oper DOWN X means the port is admin DOWN and disabled N/A for the rest abnormal scenarios - Refactor the code Signed-off-by: Shu0T1an ChenG <[email protected]>
Contributor
Author
|
taoyl-ms
approved these changes
Oct 16, 2017
lguohan
approved these changes
Oct 17, 2017
Contributor
|
update your comment: The current state field has four choices: U, D, X, N/A |
Contributor
Author
|
yes the comment is updated. |
vdahiya12
pushed a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Jul 23, 2021
…alizeGlobalConfig (sonic-net#130) The check for multiAsic before calling initializeGlobalConfig was done in xcvrd earlier. Adding now to the other processes in sonic-platform-daemons as well.
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
…od (sonic-net#130) ChassisBase and ModuleBase inherit from the DeviceBase class, which already provides a get_serial() method. Thus, these methods were redundant.
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-utilities
that referenced
this pull request
Mar 20, 2025
sonic-net#130) ```<br>* b188342f - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-utilities into 202412 (2025-02-23) [Sonic Automation] * 5cc1012 - (origin/202411) [202411][FC] remove FC delay field (sonic-net#3768) (2025-02-21) [Stepan Blyshchak] * 8ceba38 - [QOS] Skip showing unnecessary warning message (sonic-net#3762) (2025-02-11) [mssonicbld] * 04b60e2 - Fix call for spanning-tree commands in dump script (sonic-net#3752) (2025-02-07) [mssonicbld] * bbe29ae - [show][interface] Add changes for show interface errors command (sonic-net#3749) (2025-02-04) [mssonicbld]<br>```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current state field has four choices: U, D, X, N/A
U means the port is admin + oper status UP
D means the port is admin UP but oper DOWN
X means the port is admin DOWN
N/A for the rest abnormal scenarios
Signed-off-by: Shu0T1an ChenG [email protected]