Remove unnecessary calls to str.encode() now that the package is Python 3; Fix deprecation warning#1260
Merged
jleveque merged 2 commits intosonic-net:masterfrom Nov 22, 2020
jleveque:remove_encode
Merged
Remove unnecessary calls to str.encode() now that the package is Python 3; Fix deprecation warning#1260jleveque merged 2 commits intosonic-net:masterfrom jleveque:remove_encode
jleveque merged 2 commits intosonic-net:masterfrom
jleveque:remove_encode
Conversation
…hat the package is Python 3
jleveque
changed the title
jleveque
changed the title
jleveque
changed the title
lguohan
approved these changes
Nov 22, 2020
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 3, all strings are unicode by default. There is no need to encode strings to bytes.
Fixes vsimage check build failure in sonic-net/sonic-buildimage#5926, due to caclmgrd test failing because acl-loader was encoding the table names to bytes and comparing them against strings, thus failing to match table names and therefore failing to load ACL rules.
Also fix Python 3 deprecation warning in decode-syseeprom, as the
impmodule is deprecated in favor ofimportlib