[MultiDB] add MultiDB warmboot support - backing up database#1205
[MultiDB] add MultiDB warmboot support - backing up database#1205qiluo-msft merged 2 commits intosonic-net:masterfrom
Conversation
|
@qiluo-msft These two PRs are for multiDB warmboot support as proposed earlier. |
scripts/migrate_warmboot_database
Outdated
| args = parser.parse_args() | ||
|
|
||
| if args.target_db: | ||
| try: |
There was a problem hiding this comment.
[](start = 0, length = 12)
too much indentation. #Closed
scripts/fast-reboot
Outdated
| docker exec -i database rm /var/lib/redis/$REDIS_FILE | ||
|
|
||
| # move all db data into instances where APPL_DB locates | ||
| migrate_warmboot_database APPL_DB |
There was a problem hiding this comment.
migrate_warmboot_database [](start = 4, length = 25)
The name is misleading. It is not directly related to warmboot.
Suggestion centralize_database
#Closed
| dbport = swsssdk.SonicDBConfig.get_port(dbname) | ||
| # if the db is on the same instance, no need to migrate | ||
| if dbport == target_dbport: | ||
| continue |
There was a problem hiding this comment.
Is it enough to determine "the same instance" ? #Closed
There was a problem hiding this comment.
good catch. hostname plus port is enough to determine the "unique instance" . Updated
scripts/fast-reboot
Outdated
| # move all db data into instances where APPL_DB locates | ||
| migrate_warmboot_database APPL_DB | ||
|
|
||
| inst=`/usr/bin/python -c "import swsssdk; print(swsssdk.SonicDBConfig.get_instancename('APPL_DB'))"` |
There was a problem hiding this comment.
inst [](start = 4, length = 4)
Instead of using a new process to locate APPL_DB, you may just print it to stdout in above command. #Closed
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
Can you point me to the code where the centralized DB are redistributed?
* restoring each database with all data before warmboot and then flush unused data in each instance, following the multiDB warmboot design at https://github.com/Azure/SONiC/blob/master/doc/database/multi_database_instances.md * restore needs to be done in database docker since we need to know the database_config.json in new version * copy all data rdb file into each instance restoration location andthen flush unused database * other logic is the same as before * backing up database part is in another PR at sonic-utilities sonic-net/sonic-utilities#1205, they depend on each other
3 participants
Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com