[show] fix "show interfaces breakout" command by dmytroxshevchuk · Pull Request #1198 · sonic-net/sonic-utilities

dmytroxshevchuk · 2020-10-28T11:58:31Z

- What I did
Fixed show interface breakout command

- How I did it

- How to verify it
From command line type show interface breakout

- Previous command output (if the output of a command-line utility has changed)

Traceback (most recent call last):
  File "/usr/local/bin/show", line 10, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 1114, in invoke
    return Command.invoke(self, ctx)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/show/interfaces/__init__.py", line 135, in breakout
    config_db = ConfigDBConnector()
NameError: global name 'ConfigDBConnector' is not defined

- New command output (if the output of a command-line utility has changed)
Related from DPB config.
e.g.

{
    "Ethernet0": {
        "index": "0,0,0,0",
        "default_brkout_mode": "1x100G[40G]",
        "child ports": "Ethernet0",
        "breakout_modes": "1x100G[40G],2x50G,4x25G[10G],2x25G(2)+1x50G(2),1x50G(2)+2x25G(2)",
        "child port speeds": "100G",
        "Current Breakout Mode": "1x100G[40G]",
        "lanes": "25,26,27,28",
        "alias_at_lanes": "Ethernet0/0,Ethernet0/1,Ethernet0/2,Ethernet0/3"
    }
}

dmytroxshevchuk · 2020-10-30T12:09:16Z

Fixed fails:

File "/usr/local/lib/python2.7/dist-packages/show/interfaces/__init__.py", line 135, in breakout
  config_db = ConfigDBConnector()
NameError: global name 'ConfigDBConnector' is not defined

File "/usr/local/lib/python2.7/dist-packages/show/interfaces/__init__.py", line 148, in breakout
  platform_path, hwsku_path = device_info.get_paths_to_platform_and_hwsku_dirs()
NameError: global name 'device_info' is not defined

File "/usr/local/lib/python2.7/dist-packages/show/interfaces/__init__.py", line 150, in breakout
  platform_file = os.path.join(platform_path, PLATFORM_JSON)
1 import json
NameError: global name 'os' is not defined

File "/usr/local/lib/python2.7/dist-packages/show/interfaces/__init__.py", line 151, in breakout
  platform_file = os.path.join(platform_path, PLATFORM_JSON)
NameError: global name 'PLATFORM_JSON' is not defined

File "/usr/local/lib/python2.7/dist-packages/show/interfaces/__init__.py", line 154, in breakout
  platform_dict = readJsonFile(platform_file)['interfaces']
NameError: global name 'readJsonFile' is not defined

File "/usr/local/lib/python2.7/dist-packages/show/interfaces/__init__.py", line 180, in breakout
  child_port_dict = get_child_ports(port_name, cur_brkout_mode, platformFile)
NameError: global name 'get_child_ports' is not defined

File "/usr/local/lib/python2.7/dist-packages/show/interfaces/__init__.py", line 181, in breakout
  child_port_dict = get_child_ports(port_name, cur_brkout_mode, platformFile)
NameError: global name 'platformFile' is not defined

File "/usr/local/lib/python2.7/dist-packages/show/interfaces/__init__.py", line 200, in breakout
  parsed = OrderedDict((k, platform_dict[k]) for k in natsorted(platform_dict.keys()))
NameError: global name 'OrderedDict' is not defined

dmytroxshevchuk · 2020-11-02T10:34:02Z

@daall @lguohan please review

lguohan · 2020-11-05T08:46:35Z

@praveen-li to review

rbone-mitre · 2020-11-10T23:27:23Z

Hope this fix can be pushed soon

praveen-li · 2020-11-10T23:48:32Z

show/interfaces/__init__.py

@samaity : Hi Sangita, as I know, we do not provide platform.json like this. We need a call to device_info.get_path_to_port_config_file(). Kindly confirm, if yes, I will mark it as a change needed.

@praveen-li, I saw device_info.get_path_to_port_config_file() logic, I think its better way to find PLATFORM.json, so PR was updated.
Please take a look.

We didn't have get_path_to_port_config_file available when the show breakout functionality was added. This is absolutely the better way to get the path. Thanks for the update!

lgtm-com · 2020-11-20T10:39:13Z

This pull request introduces 2 alerts when merging 002d8587cb30db2275cf8f595fc8190146af0276 into 05c8e33 - view on LGTM.com

new alerts:

2 for Module is imported more than once

lgtm-com · 2020-11-20T10:47:28Z

This pull request introduces 2 alerts when merging d93dae67e644c25a3010469c52b8dcfed088455c into 05c8e33 - view on LGTM.com

new alerts:

2 for Module is imported more than once

dmytroxshevchuk · 2020-12-16T10:31:26Z

@praveen-li @daall @lguohan can we merge this PR? its very comfortably to see information related to DPB using show command

praveen-li

Look Good to Me.
@samaity for quick double-check.

samaity · 2020-12-17T20:07:30Z

Look Good to Me.
@samaity for quick double-check.

Looks good to me.

Look Good to Me.
@samaity for quick double-check.

LGTM 👍

dmytroxshevchuk · 2020-12-18T09:15:01Z

@praveen-li @samaity thanks for the review

@lguohan @daall can we merge it now?

dmytroxshevchuk · 2021-01-20T15:34:56Z

@vdahiya12 @qiluo-msft @renukamanavalan please take a look and review/merge this PR. Thanks.

qiluo-msft · 2021-01-21T03:09:36Z

show/interfaces/__init__.py

+    try:
+        with open(fileName) as f:
+            result = json.load(f)
+    except Exception as e:


Exception [](start = 11, length = 9)

Could you catch the specific type/types? such as file exception, json format exceptions, etc? #Closed

qiluo-msft · 2021-01-21T03:10:28Z

show/interfaces/__init__.py

+        with open(fileName) as f:
+            result = json.load(f)
+    except Exception as e:
+        click.echo(str(e))


echo [](start = 14, length = 4)

echo to stderr #Closed

dmytroxshevchuk · 2021-01-21T13:39:09Z

@qiluo-msft done, please check

…out command

dmytroxshevchuk · 2021-01-27T15:30:57Z

@qiluo-msft please merge

**- What I did** Fixed `show interface breakout` command **- How I did it** **- How to verify it** From command line type `show interface breakout` **- Previous command output (if the output of a command-line utility has changed)** ``` Traceback (most recent call last): File "/usr/local/bin/show", line 10, in <module> sys.exit(cli()) File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 764, in __call__ return self.main(*args, **kwargs) File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 717, in main rv = self.invoke(ctx) File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 1137, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 1137, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 1114, in invoke return Command.invoke(self, ctx) File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 956, in invoke return ctx.invoke(self.callback, **ctx.params) File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 555, in invoke return callback(*args, **kwargs) File "/usr/local/lib/python2.7/dist-packages/click/decorators.py", line 17, in new_func return f(get_current_context(), *args, **kwargs) File "/usr/local/lib/python2.7/dist-packages/show/interfaces/__init__.py", line 135, in breakout config_db = ConfigDBConnector() NameError: global name 'ConfigDBConnector' is not defined ``` **- New command output (if the output of a command-line utility has changed)** Related from DPB config. e.g. ``` { "Ethernet0": { "index": "0,0,0,0", "default_brkout_mode": "1x100G[40G]", "child ports": "Ethernet0", "breakout_modes": "1x100G[40G],2x50G,4x25G[10G],2x25G(2)+1x50G(2),1x50G(2)+2x25G(2)", "child port speeds": "100G", "Current Breakout Mode": "1x100G[40G]", "lanes": "25,26,27,28", "alias_at_lanes": "Ethernet0/0,Ethernet0/1,Ethernet0/2,Ethernet0/3" } } ```

qiluo-msft · 2021-03-04T19:38:44Z

swsssdk is deprecated largely in sonic-utilities. Could you adapt the new ConfigDBConnector as in latest code?

dmytroxshevchuk force-pushed the fix_breakout_show branch from 52e069b to ad1ca76 Compare October 30, 2020 08:54

dmytroxshevchuk changed the title ~~fix show breakout port~~ [show] fix show breakout port Oct 30, 2020

dmytroxshevchuk changed the title ~~[show] fix show breakout port~~ [show] fix "show interfaces breakout" command Oct 30, 2020

praveen-li requested changes Nov 10, 2020

View reviewed changes

fix show breakout port

b324e90

dmytroxshevchuk force-pushed the fix_breakout_show branch 2 times, most recently from c65dfe2 to 002d858 Compare November 20, 2020 10:32

dmytroxshevchuk force-pushed the fix_breakout_show branch from 002d858 to d93dae6 Compare November 20, 2020 10:40

dmytroxshevchuk force-pushed the fix_breakout_show branch 2 times, most recently from 1bf7554 to b324e90 Compare November 20, 2020 12:07

praveen-li previously approved these changes Dec 17, 2020

View reviewed changes

samaity previously approved these changes Dec 17, 2020

View reviewed changes

dmytroxshevchuk mentioned this pull request Jan 19, 2021

show interfaces breakout not working sonic-net/sonic-buildimage#5343

Closed

qiluo-msft reviewed Jan 21, 2021

View reviewed changes

dmytroxshevchuk dismissed stale reviews from samaity and praveen-li via 344d455 January 21, 2021 13:38

[show] specify exception while read json file in show interface break…

344d455

…out command

qiluo-msft approved these changes Jan 21, 2021

View reviewed changes

qiluo-msft merged commit c7c01e4 into sonic-net:master Jan 27, 2021

dmytroxshevchuk mentioned this pull request Feb 2, 2021

[DPB] Command not working "show interface breakout" sonic-net/sonic-buildimage#6608

Closed

zhenggen-xu added the Request for 202012 Branch label Feb 4, 2021

zhenggen-xu mentioned this pull request Feb 4, 2021

[submodule] Update sonic-utilities sonic-net/sonic-buildimage#6589

Closed

yxieca added the Included in 202012 Branch label Feb 23, 2021

Conversation

dmytroxshevchuk commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dmytroxshevchuk commented Oct 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dmytroxshevchuk commented Nov 2, 2020

Uh oh!

lguohan commented Nov 5, 2020

Uh oh!

rbone-mitre commented Nov 10, 2020

Uh oh!

praveen-li Nov 10, 2020

Choose a reason for hiding this comment

Uh oh!

dmytroxshevchuk Nov 20, 2020

Choose a reason for hiding this comment

Uh oh!

samaity Dec 17, 2020

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented Nov 20, 2020

Uh oh!

lgtm-com bot commented Nov 20, 2020

Uh oh!

dmytroxshevchuk commented Dec 16, 2020

Uh oh!

praveen-li left a comment

Choose a reason for hiding this comment

Uh oh!

samaity commented Dec 17, 2020

Uh oh!

dmytroxshevchuk commented Dec 18, 2020

Uh oh!

dmytroxshevchuk commented Jan 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qiluo-msft Jan 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Jan 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmytroxshevchuk commented Jan 21, 2021

Uh oh!

dmytroxshevchuk commented Jan 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qiluo-msft commented Mar 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

dmytroxshevchuk commented Oct 28, 2020 •

edited

Loading

dmytroxshevchuk commented Oct 30, 2020 •

edited

Loading

dmytroxshevchuk commented Jan 20, 2021 •

edited

Loading

qiluo-msft Jan 21, 2021 •

edited

Loading

qiluo-msft Jan 21, 2021 •

edited

Loading

dmytroxshevchuk commented Jan 27, 2021 •

edited

Loading