[pfcstat] Create new copies of Rx and Tx dictionaries#1150
Merged
neethajohn merged 3 commits intosonic-net:masterfrom Oct 7, 2020
Merged
[pfcstat] Create new copies of Rx and Tx dictionaries#1150neethajohn merged 3 commits intosonic-net:masterfrom
neethajohn merged 3 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
Contributor
|
Looks good. Thanks for working on the fix!! |
lguohan
approved these changes
Oct 7, 2020
abdosi
pushed a commit
that referenced
this pull request
Oct 13, 2020
* Fix the issue where Rx counts were overwritten by the Tx counts Signed-off-by: Neetha John <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
[pfcstat] Create new copies of Rx and Tx dictionaries (sonic-net#1150) [config] Reload Monit configuration after potential hostname changes (sonic-net#1132) Signed-off-by: Abhishek Dosi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fixes sonic-net/sonic-buildimage#5540
The issue was due to pfcstat rx and tx dict values copied using '=' and hence the Rx counts were always getting overwritten by the Tx counts
Unit tests didn't catch the problem because the Tx and Rx counts were set to the same value.
- How I did it
create new copies of pfcstat Rx and Tx dictionaries
Updated unit tests to use different values for Tx and Rx counts
- How to verify it
Without the change, modified the mock counter values for Rx and Tx to be different. The pfcstat tests were failing.
With the changes, send PFC pause frames from the fanout and from the DUT and ensured that values were getting reflected correctly for Rx and Tx.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)