mclag enhancements as per HLD at Azure/SONIC#596 by gitsabari · Pull Request #1138 · sonic-net/sonic-utilities

gitsabari · 2020-09-28T23:38:22Z

What I did
This PR contains the code changes to support click cli changes for mclag enhancements as per HLD sonic-net/SONiC#596

Why I did it
Implemented as per the MCLAG enhancements HLD: sonic-net/SONiC#596

How I verified it
Mclag specific VS tests included part of check-in.

Details:
The PR includes the click cli changes as part of MCLAG enhancements
This PR must work with submitted PR's in other sonic repositories which are listed below.
> Iccpd: sonic-net/sonic-buildimage#4819
> Swss: sonic-net/sonic-swss#1331
> swss-common: sonic-net/sonic-swss-common#405
> Mclagsyncd: sonic-net/sonic-swss#1349
> Mgmt-FW: sonic-net/sonic-mgmt-framework#59
added mclag sonic yang file sonic-net/sonic-buildimage#7622

lgtm-com · 2020-09-28T23:44:37Z

This pull request introduces 1 alert when merging 73f90d2 into 07a4e26 - view on LGTM.com

new alerts:

1 for Unnecessary pass

tapashdas · 2020-11-26T06:57:59Z

retest this please

…c-utilities into mclag_enhacements

gitsabari · 2021-01-06T18:11:46Z

@gechiang , @lguohan, @rlhui
can you please help review and approve this merge request

gitsabari · 2021-01-13T00:42:47Z

@gechiang , @lguohan, @rlhui
can you please help review and approve this merge request

gitsabari · 2021-02-22T22:35:30Z

retest this please

gitsabari · 2021-02-22T22:35:46Z

retest this please

gitsabari · 2021-02-22T22:43:30Z

@rathnasabapathyv , @prvattem
can you please approve this PR if there are no more questions

tests/mclag_test.py

gitsabari · 2021-07-14T16:22:36Z

the unit test only checks the cli return value, in other unit test, it also checks if the config db is correct or not. not sure why this unit test does not validate config db values.

@lguohan thanks for the comments. addressed it in latest

gitsabari · 2021-07-14T19:09:28Z

@arlakshm have addressed all comments and all checks are passed. please help approve and merge the changes

config/mclag.py

arlakshm

lgtm, one minor comment.

haslersn · 2021-07-16T13:00:53Z

Can this get merged?

* mclagsyncd enhancements as per HLD at sonic-net/SONiC#596 * addressed LGTM alert * UT Fix unique IP configuration * modified ip address validate function for mclag config verication * Add soft-reboot reboot type (sonic-net#1453) What I did Add a new reboot named as soft-reboot which can be performed by "kexec -e" How I did it Replace the platform reboot with "kexec -e" for the cold reboot case. How to verify it Verified the reboot on DUT and check the reboot-cause * [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (sonic-net#1460) Check if any warm restart flag is set when issuing a warm-reboot. This check avoids starting a warm reboot while another warm restart is in progress. In the scenario where a warm reboot is issued with another warm restart in progress, the warm restart flag may be reset and part of the components have a risk of doing cold reboot. * Added mclag config commands * removed unwanted imports * added mclag tests * fixed build issue * corrected mclag test * corrected mclag test * corrected mclag test case * updated testcase for mclag * updated mclag config * updated mclag test cases * updated mclag test case * updated mclag test cases * fixed alert * updated mclag test cases * updated mclag test cases * updated mclag config * modified mclag test cases * updated mclag test case * updated mclag test case * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test case * updated mclag test case * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test case * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test case * updated mclag test cases * updated mclag test case * updated mclag config to use swsscommon instead of swssdk * updated mclag config to use swsscommon * updated mclag config script file * fixed mclag test cases to verify config db * updated mclag test case with config db verify function * fixed build issue * updated test case * updated mclag test case * addressed review comments Co-authored-by: Tapash Das <tapash.das@broadcom.com> Co-authored-by: Tapash Das <48195098+tapashdas@users.noreply.github.com> Co-authored-by: Sujin Kang <sujkang@microsoft.com> Co-authored-by: Shi Su <67605788+shi-su@users.noreply.github.com>

* mclagsyncd enhancements as per HLD at sonic-net/SONiC#596 * addressed LGTM alert * UT Fix unique IP configuration * modified ip address validate function for mclag config verication * Add soft-reboot reboot type (#1453) What I did Add a new reboot named as soft-reboot which can be performed by "kexec -e" How I did it Replace the platform reboot with "kexec -e" for the cold reboot case. How to verify it Verified the reboot on DUT and check the reboot-cause * [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (#1460) Check if any warm restart flag is set when issuing a warm-reboot. This check avoids starting a warm reboot while another warm restart is in progress. In the scenario where a warm reboot is issued with another warm restart in progress, the warm restart flag may be reset and part of the components have a risk of doing cold reboot. * Added mclag config commands * removed unwanted imports * added mclag tests * fixed build issue * corrected mclag test * corrected mclag test * corrected mclag test case * updated testcase for mclag * updated mclag config * updated mclag test cases * updated mclag test case * updated mclag test cases * fixed alert * updated mclag test cases * updated mclag test cases * updated mclag config * modified mclag test cases * updated mclag test case * updated mclag test case * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test case * updated mclag test case * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test case * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test cases * updated mclag test case * updated mclag test cases * updated mclag test case * updated mclag config to use swsscommon instead of swssdk * updated mclag config to use swsscommon * updated mclag config script file * fixed mclag test cases to verify config db * updated mclag test case with config db verify function * fixed build issue * updated test case * updated mclag test case * addressed review comments Co-authored-by: Tapash Das <tapash.das@broadcom.com> Co-authored-by: Tapash Das <48195098+tapashdas@users.noreply.github.com> Co-authored-by: Sujin Kang <sujkang@microsoft.com> Co-authored-by: Shi Su <67605788+shi-su@users.noreply.github.com>

mclagsyncd enhancements as per HLD at sonic-net/SONiC#596

73f90d2

gitsabari changed the title ~~mclagsyncd enhancements as per HLD at Azure/SONIC#596~~ mclag enhancements as per HLD at Azure/SONIC#596 Sep 28, 2020

This was referenced Oct 30, 2020

Mclag enhacements sonic-net/sonic-swss#1349

Merged

mclag enhancements as per HLD at Azure/SONIC#596 sonic-net/sonic-mgmt-framework#59

Merged

mclag enhancements as per HLD at Azure/SONIC#596 sonic-net/sonic-mgmt-common#25

Closed

rathnasabapathyv previously approved these changes Nov 11, 2020

View reviewed changes

Updated code.

e31a0e4

tapashdas dismissed rathnasabapathyv’s stale review via e31a0e4 November 11, 2020 07:22

This comment has been minimized.

Sign in to view

gitsabari and others added 2 commits November 17, 2020 16:29

addressed LGTM alert

82dedb0

Updated code.

4f6aaee

gitsabari added 2 commits December 30, 2020 12:51

Merge branch 'master' into mclag_enhacements

303d277

Merge branch 'mclag_enhacements' of https://github.com/gitsabari/soni…

fb37d6c

…c-utilities into mclag_enhacements

tapashdas and others added 3 commits January 8, 2021 12:41

UT Fix unique IP configuration

bfac892

Merge branch 'master' into mclag_enhacements

7d3e270

modified ip address validate function for mclag config verication

325b50b

rathnasabapathyv previously approved these changes Feb 24, 2021

View reviewed changes

Merge branch 'master' into mclag_enhacements

004017c

gitsabari dismissed rathnasabapathyv’s stale review via 004017c March 2, 2021 06:46

gitsabari added 9 commits July 13, 2021 15:58

fixed mclag test cases to verify config db

147f31c

updated mclag test case with config db verify function

1848e02

fixed build issue

6f8c74f

fixed build issue

e376034

fixed build issue

a4c0a85

fixed build issue

26fd979

fixed build issue

ba901c6

fixed build issue

c47e5de

fixed build issue

489c5b3

haslersn reviewed Jul 14, 2021

View reviewed changes

tests/mclag_test.py Outdated Show resolved Hide resolved

tests/mclag_test.py Outdated Show resolved Hide resolved

tests/mclag_test.py Outdated Show resolved Hide resolved

gitsabari added 7 commits July 14, 2021 01:27

updated test case

d5db6f8

updatrd mclag test case

59bb702

updated mclag test case

a506c73

updated mclag test case

de8ba45

updated mclag test case

7c27d18

updated mclag test case

95293db

updated mclag test case

379b60e

arlakshm reviewed Jul 15, 2021

View reviewed changes

config/mclag.py Outdated Show resolved Hide resolved

arlakshm reviewed Jul 15, 2021

View reviewed changes

addressed review comments

f95967c

arlakshm self-requested a review July 16, 2021 00:07

arlakshm approved these changes Jul 16, 2021

View reviewed changes

gechiang merged commit 0efd297 into sonic-net:master Jul 16, 2021

judyjoseph added the Request for 202106 Branch label Aug 7, 2021

judyjoseph added the Included in 202106 Branch label Aug 20, 2021

Conversation

gitsabari commented Sep 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com bot commented Sep 28, 2020

Uh oh!

This comment has been minimized.

tapashdas commented Nov 26, 2020

Uh oh!

gitsabari commented Jan 6, 2021

Uh oh!

gitsabari commented Jan 13, 2021

Uh oh!

gitsabari commented Feb 22, 2021

Uh oh!

gitsabari commented Feb 22, 2021

Uh oh!

gitsabari commented Feb 22, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gitsabari commented Jul 14, 2021

Uh oh!

gitsabari commented Jul 14, 2021

Uh oh!

Uh oh!

arlakshm left a comment

Choose a reason for hiding this comment

Uh oh!

haslersn commented Jul 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

gitsabari commented Sep 28, 2020 •

edited

Loading