Enhancement of 'show' commands and addition of 'debug', and 'undebug'… by samaity · Pull Request #113 · sonic-net/sonic-utilities

samaity · 2017-09-29T18:36:03Z

… hierarchy in CLI utilities

    > added script to get interface status.
    > added few subcommands under "show interfaces" command.
    > enhanced "show process" to get all processes sorted by CPU & memory.
    > added "show services" command to get all the running process from all the dockers.
    > added "show vlan" command.
    > enhanced multiple subcommands under
    > added debug', and 'undebug' CLI utilities.

… hierarchy in CLI utilities > added script to get interface status. > added few subcommands under "show interfaces" command. > enhanced "show process" to get all processes sorted by CPU & memory. > added "show services" command to get all the running process from all the dockers. > added "show vlan" command. > enhanced multiple subcommands under > added debug', and 'undebug' CLI utilities.

msftclas · 2017-09-29T18:36:12Z

All CLA requirements met.

jleveque · 2017-09-29T19:24:14Z

debug/main.py

+
+
+# Add 'bgp' group to both the root 'cli' group and the 'ip' subgroup
+cli.add_command(bgp)


This is unnecessary, as bgp is added to the cli group only, and this is done via the decorator on line 110.

jleveque · 2017-09-29T19:27:50Z

show/main.py

-# 'summary' subcommand ("show interfaces summary")
-@interfaces.command()
+# 'summary' subcommand ("show interfaces summary") -- called if no subcommands are passed
+@interfaces.command(default=True)


I am not a fan of the DefaultGroup we have implemented using Click, because when a group has a default command, it does not allow for using Tab to show available subcommands.

We either need to eliminate default commands for groups altogether, or try to fix our DefaultGroup to allow the Tab functionality to work.

For the time being, will get rid of this 'default' behavior. Agree that 'tabs' is a nice-to-have feature.

jleveque · 2017-09-29T19:29:53Z

scripts/interface_stat

+	a = self.db.keys(self.db.APPL_DB)
+	#print(a)
+	tables = self.db.keys(self.db.APPL_DB, "PORT_TABLE:*")
+	i={}


Add spaces around = for consistent style.

jleveque · 2017-09-29T19:32:17Z

debug/main.py

+
+
+# Add 'bgp' group to both the root 'cli' group and the 'ip' subgroup
+cli.add_command(bgp)


This line is unnecessary, as bgp is only added to the cli group, and this is already done via the decorator on line 110.

jleveque · 2017-09-29T19:33:14Z

debug/main.py

+
+@click.group(cls=AliasedGroup, context_settings=CONTEXT_SETTINGS)
+def cli():
+	"""SONiC command line - 'debug' command"""


Replace tabs with spaces everywhere they occur within the file for consistent style

yes, just noticed the entire file was lacking indentation consistency.

jleveque · 2017-09-29T19:42:08Z

show/main.py

+    command="free -m"
+    run_command(command)
+
+@click.group(cls=AliasedGroup, default_if_no_args=False)


Change to @cli.group(cls=AliasedGroup, default_if_no_args=False) and remove cli.add_command(vlan) on line 678.

show/main.py

jleveque · 2017-09-29T19:45:55Z

show/main.py

+@click.argument('interfacename', required=False)
+def default(interfacename):
+    if interfacename is not None:
+        command = "sudo sfputil -p {}".format(interfacename)


sfputil syntax changed recently. Please update all sfputil calls here and below to new syntax.

jleveque · 2017-09-29T19:49:13Z

undebug/main.py

+
+@click.group(cls=AliasedGroup, context_settings=CONTEXT_SETTINGS)
+def cli():
+	"""SONiC command line - 'undebug' command"""


Replace tabs with spaces everywhere they occur within the file for consistent style

jleveque · 2017-09-29T19:50:17Z

undebug/main.py

+
+
+# Add 'bgp' group to both the root 'cli' group and the 'ip' subgroup
+cli.add_command(bgp)


This line is unnecessary, as bgp is only added to the cli group, and this is already done via the decorator on line 108.

jleveque · 2017-10-02T18:34:10Z

undebug/main.py

+    run_command(command)
+
+if __name__ == '__main__':
+	cli()


Replace tab with spaces.

* msft_github/master: Enhancement of 'show' commands and addition of 'debug', and 'undebug'… (sonic-net#113) CLI support for Layer 2 MAC/FDB show (sonic-net#106) [show]: Add 'show interfaces alias' command to display port name/alias mapping (sonic-net#107) Add 'ipv6' group along with 'bgp' and 'route' subcommands; Remove duplicate commands ('bgp,' 'route') from under root group (sonic-net#102) [generate_dump]: Skip the sparse file /var/log/lastlog (sonic-net#104) Added syncd SAI dump to sysdump script (sonic-net#89) Adapt to new minigraph_parser schema (sonic-net#103) [core dump] remove number of parameter assumption from script coredump-compress [FastReboot]: Update FR to make it working with 1.0.3 (sonic-net#95)

…king (sonic-net#113) This was missed in sonic-net/sonic-platform-daemons#112

sonic-net#113) ```<br>* 99a0a1ec - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-utilities into 202412 (2025-02-11) [Sonic Automation] * 8ceba38 - (origin/202411) [QOS] Skip showing unnecessary warning message (sonic-net#3762) (2025-02-11) [mssonicbld] * 04b60e2 - Fix call for spanning-tree commands in dump script (sonic-net#3752) (2025-02-07) [mssonicbld] * bbe29ae - [show][interface] Add changes for show interface errors command (sonic-net#3749) (2025-02-04) [mssonicbld]<br>```

jleveque suggested changes Sep 29, 2017

View reviewed changes

samaity force-pushed the master branch 2 times, most recently from b540049 to 7398670 Compare October 2, 2017 06:30

Updating patch with latest review-comments.

0347c46

jleveque suggested changes Oct 2, 2017

View reviewed changes

One more code-review comment to take care of.

c7ca151

jleveque approved these changes Oct 2, 2017

View reviewed changes

jleveque merged commit 63f05ad into sonic-net:master Oct 2, 2017

stcheng added the Enhancement label Oct 2, 2017

vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this pull request Jul 23, 2021

[chassisd][thermalctld] Import os module, now needed for env var chec…

2dd3b95

…king (sonic-net#113) This was missed in sonic-net/sonic-platform-daemons#112



		# Add 'bgp' group to both the root 'cli' group and the 'ip' subgroup
		cli.add_command(bgp)

Conversation

samaity commented Sep 29, 2017

Uh oh!

msftclas commented Sep 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

msftclas commented Sep 29, 2017 •

edited

Loading