Convert to Python 3

[jleveque]

- What I did

Conform syntax to support Python 3 using 2to3 tool and manual assessment

- How I did it

Using 2to3 tool as well as manual assessment

- How to verify it

Build a Python 3 version of the sonic-utilities package, install and test all applications

NOTE: This cannot currently be done, as sonic-utilities depends on sonic-config-engine and sonic-yang-mgmt, neither of which are we currently building Python 3 versions of.

• Need Python 3 version of sonic-config-engine
• Need Python 3 version of sonic-yang-mgmt

[qiluo-msft]

Suggested change

	for it in list(D1.keys()):
	for it in D1:

[jleveque]

This will not work. It would need to be:

for it, _ in D1:

I will not make a change like this in this PR. Plus, keeping .keys() makes it clear what the intention is.

[qiluo-msft]

It will work. I think you are talking about

for it, _ in D1.items():

---

In reply to: 499074240 [](ancestors = 499074240)

[jleveque]

Yes, you're correct. I misread this one. Everything started blending together after all these changes :)

I will go back through and do a cleanup pass in the future.

[jleveque]

I have opened a PR to clean up here.

[qiluo-msft]

Suggested change

	for key in list(In.keys()):
	for it in In:

[jleveque]

This will not work. It would need to be:

for it, _ in In:

I will not make a change like this in this PR. Plus, keeping .keys() makes it clear what the intention is.

[qiluo-msft]

Suggested change

	for intf in list(del_intf_dict.keys()):
	for intf in del_intf_dict:

[jleveque]

This will not work. It would need to be:

for intf, _ in del_intf_dict:

I will not make a change like this in this PR. Plus, keeping .keys() makes it clear what the intention is.

[qiluo-msft]

list [](start = 28, length = 4)

The same

[jleveque]

This will not work. It would need to be:

for feature_name, _ in feature_table:

I will not make a change like this in this PR. Plus, keeping .keys() makes it clear what the intention is.

[qiluo-msft]

list [](start = 18, length = 4)

The same

[jleveque]

This will not work. It would need to be something like:

for (_,intf), _ in vlan_member_table:

I will not make a change like this in this PR. Plus, keeping .keys() makes it clear what the intention is.

[jleveque]

However, I did add a space after the comma.

[lgtm-com]

This pull request fixes 8 alerts when merging 0dba073cabd8479f92a446f095c7355795f29841 into 8079558 - view on LGTM.com

fixed alerts:

• 6 for Variable defined multiple times
• 2 for Unused local variable

[lgtm-com]

This pull request fixes 8 alerts when merging 800350f into 8079558 - view on LGTM.com

fixed alerts:

• 6 for Variable defined multiple times
• 2 for Unused local variable

[lguohan]