Skip to content

[pfcwd] Fix stats crash with invalid queue name#1077

Merged
neethajohn merged 1 commit intosonic-net:masterfrom
neethajohn:pfcwd_stats_fix
Aug 26, 2020
Merged

[pfcwd] Fix stats crash with invalid queue name#1077
neethajohn merged 1 commit intosonic-net:masterfrom
neethajohn:pfcwd_stats_fix

Conversation

@neethajohn
Copy link
Contributor

Signed-off-by: Neetha John [email protected]

Pfcwd show stats was crashing when an invalid queue name was specified as argument
fixes #1076

- What I did
Retreive stats only for valid queue names

- How to verify it
With the fix,

admin@str-7260cx3-acs-7:~$ pfcwd show stats Ethernet0:30                         
  QUEUE    STATUS    STORM DETECTED/RESTORED    TX OK/DROP    RX OK/DROP    TX LAST OK/DROP    RX LAST OK/DROP
-------  --------  -------------------------  ------------  ------------  -----------------  -----------------

@neethajohn
Copy link
Contributor Author

retest this please

@neethajohn neethajohn merged commit 58c2961 into sonic-net:master Aug 26, 2020
@neethajohn neethajohn deleted the pfcwd_stats_fix branch August 26, 2020 23:37
yxieca pushed a commit that referenced this pull request Aug 31, 2020
abdosi pushed a commit that referenced this pull request Sep 3, 2020
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
Fix error when running 'show lldp table' or 'show lldp neighbor'
through SSH command. (sonic-net#1067)
[201911]: Multi asic show interface support (sonic-net#1070)
[counterpoll] Add new FC group for port buffer drop counters
(sonic-net#1024)
[201911] show interface portchannel support for Multi ASIC
(sonic-net#1071)
Fix a typo in mellanox_buffer_migrator (sonic-net#1090)
Fix pfcwd stats crash with invalid queue name (sonic-net#1077)
[PFCWD] Fix issue with "pfcwd show stats" command during SONiC init
(sonic-net#1018)
enable watchdog before running platform specific reboot plugin
(sonic-net#1037)
Add namespace of the process in the coredump filename. (sonic-net#1091)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pfcwd show stats crash with invalid queue name

4 participants