[tests]: fix drops_group_test failure on second run#1023
Merged
lguohan merged 2 commits intosonic-net:masterfrom Aug 3, 2020
Merged
[tests]: fix drops_group_test failure on second run#1023lguohan merged 2 commits intosonic-net:masterfrom
lguohan merged 2 commits intosonic-net:masterfrom
Conversation
jleveque
previously approved these changes
Aug 3, 2020
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
I'm not familiar with the logic of the test itself, but the change looks good and makes sense.
a few tests in drops_group_test fails on second run. The reason is that /tmp/dropstat is not cleaned, the first run leave some state in the folder which cause the subsequent run to fail. The fix is the always clean up the folder. Signed-off-by: Guohan Lu <lguohan@gmail.com>
|
This pull request fixes 1 alert when merging e4a0c7e74e62843f8a8946b17f8acfbdb02f92fe into c0c3cce - view on LGTM.com fixed alerts:
|
Contributor
Author
|
test failure is not related this pr. |
daall
approved these changes
Aug 3, 2020
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
1. remove container feature table 2. do not generate feature entry if the feature is not included in the image 3. rename ENABLE_* to INCLUDE_* for better clarity 4. rename feature status to feature state 5. [submodule]: update sonic-utilities * 9700e45 2020-08-03 | [show/config]: combine feature and container feature cli (sonic-net#1015) (HEAD, origin/master, origin/HEAD) [lguohan] * c9d3550 2020-08-03 | [tests]: fix drops_group_test failure on second run (sonic-net#1023) [lguohan] * dfaae69 2020-08-03 | [lldpshow]: Fix input device is not a TTY error (sonic-net#1016) [Arun Saravanan Balachandran] * 216688e 2020-08-02 | [tests]: rename sonic-utilitie-tests to tests (sonic-net#1022) [lguohan] Signed-off-by: Guohan Lu <lguohan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guohan Lu lguohan@gmail.com
- What I did
a few tests in drops_group_test fails on second run.
The reason is that /tmp/dropstat is not cleaned, the first
run leave some state in the folder which cause the subsequent
run to fail.
The fix is the always clean up the folder.
- How I did it
The fix is the always clean up the folder.
- How to verify it
run python setup.py test multiple times.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)