Skip to content

Trap DHCPv6 packets for supporting ZTP over in-band interfaces using …#997

Merged
lguohan merged 2 commits intosonic-net:masterfrom
rajendra-dendukuri:ztp_copp_changes
Jul 31, 2019
Merged

Trap DHCPv6 packets for supporting ZTP over in-band interfaces using …#997
lguohan merged 2 commits intosonic-net:masterfrom
rajendra-dendukuri:ztp_copp_changes

Conversation

@rajendra-dendukuri
Copy link
Contributor

…DHCPv6 discovery

Also increase incoming packet rate on in-band interfaces to support faster
download of large files. SONiC firmware image download over in-band can
take a lot of time if the incoming packet rate is limited to 600pps. This,
change increases it to 6000pps.

Signed-off-by: Rajendra Dendukuri [email protected]

What I did
Increased packet rate for traffic destined to CPU.

Added DHCPv6 to trap list to support ZTP over IPv6 transport.

Why I did it
This is required for ZTP to download large files over in-band interface.
Support ZTP over IPv6 transport.

How I verified it
ZTP over in-band interface

Details if related

…DHCPv6 discovery

Also increase incoming packet rate on in-band interfaces to support faster
download of large files. SONiC firmware image download over in-band can
take a lot of time if the incoming packet rate is limited to 600pps. This,
change increases it to 6000pps.

Signed-off-by: Rajendra Dendukuri <[email protected]>
Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you separate this pull request into two different pull requests? They are serving different purposes.
Also, changing the CIR/CBS of the current policer might change the current image's behavior and stability. At least it will break the current tests which might not be desired at this moment.

Signed-off-by: Rajendra Dendukuri <[email protected]>
@rajendra-dendukuri
Copy link
Contributor Author

Could you separate this pull request into two different pull requests? They are serving different purposes.
Also, changing the CIR/CBS of the current policer might change the current image's behavior and stability. At least it will break the current tests which might not be desired at this moment.

As suggested, I moved the ip2me policer changes to a different PR #1000

Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check if the current vendor's SAI implementations support this or not before merging it. Thanks for the update!

@rajendra-dendukuri
Copy link
Contributor Author

rajendra-dendukuri commented Jul 30, 2019

retest vs

@stcheng
Copy link
Contributor

stcheng commented Jul 30, 2019

retest this please

@lguohan lguohan merged commit 8e50633 into sonic-net:master Jul 31, 2019
tonytitus pushed a commit to tonytitus/sonic-swss that referenced this pull request Jul 31, 2019
sonic-net#997)

* Trap DHCPv6 packets for supporting ZTP over in-band interfaces using DHCPv6 discovery

Also increase incoming packet rate on in-band interfaces to support faster
download of large files. SONiC firmware image download over in-band can
take a lot of time if the incoming packet rate is limited to 600pps. This,
change increases it to 6000pps.

Signed-off-by: Rajendra Dendukuri <[email protected]>
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
sonic-net#997)

* Trap DHCPv6 packets for supporting ZTP over in-band interfaces using DHCPv6 discovery

Also increase incoming packet rate on in-band interfaces to support faster
download of large files. SONiC firmware image download over in-band can
take a lot of time if the incoming packet rate is limited to 600pps. This,
change increases it to 6000pps.

Signed-off-by: Rajendra Dendukuri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants