Skip to content

[test]: Add Class object in each test script file#992

Merged
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:test
Jul 28, 2019
Merged

[test]: Add Class object in each test script file#992
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:test

Conversation

@stcheng
Copy link
Copy Markdown
Contributor

@stcheng stcheng commented Jul 24, 2019

This is to get a better JUnitXML file and align all
the tests under the same level of hierarchy.

Signed-off-by: Shu0T1an ChenG [email protected]

@stcheng stcheng requested a review from lguohan July 24, 2019 20:30
@stcheng
Copy link
Copy Markdown
Contributor Author

stcheng commented Jul 24, 2019

https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/sonic-swss-build/test_results_analyzer/

to have a better view in the test results analyzer, all the tests need to be put into separated class objects. otherwise, they will be put under (root) directory.

@sonic-net sonic-net deleted a comment from lguohan Jul 25, 2019
@sonic-net sonic-net deleted a comment from lguohan Jul 25, 2019
@sonic-net sonic-net deleted a comment from lguohan Jul 25, 2019
@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Jul 25, 2019

I ran multiple tests, I suspect there is some genuine issue in the refactoring.

This is to get a better JUnitXML file and align all
the tests under the same level of hierarchy.

Signed-off-by: Shu0T1an ChenG <[email protected]>
@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Jul 27, 2019

retest this please

2 similar comments
@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Jul 27, 2019

retest this please

@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Jul 27, 2019

retest this please

Copy link
Copy Markdown
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not merge yet, I found the refactor make the test more unstable.

@stcheng
Copy link
Copy Markdown
Contributor Author

stcheng commented Jul 27, 2019

test_warm_reboot.py::TestWarmReboot::test_system_warmreboot_neighbor_syncup FAILED

this test failed constantly others are fine
i'll check this test

@stcheng
Copy link
Copy Markdown
Contributor Author

stcheng commented Jul 28, 2019

All checks have passed
2 successful checks
https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/sonic-swss-build-pr/406/
i'll try some more

@stcheng
Copy link
Copy Markdown
Contributor Author

stcheng commented Jul 28, 2019

retest this please

2 similar comments
@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Jul 28, 2019

retest this please

@stcheng
Copy link
Copy Markdown
Contributor Author

stcheng commented Jul 28, 2019

retest this please

@stcheng stcheng merged commit 7368527 into sonic-net:master Jul 28, 2019
@stcheng stcheng deleted the test branch July 28, 2019 21:15
tonytitus pushed a commit to tonytitus/sonic-swss that referenced this pull request Jul 31, 2019
This is to get a better JUnitXML file and align all
the tests under the same level of hierarchy.

Signed-off-by: Shu0T1an ChenG <[email protected]>
antony-rheneus pushed a commit to antony-rheneus/sonic-swss that referenced this pull request Aug 1, 2019
This is to get a better JUnitXML file and align all
the tests under the same level of hierarchy.

Signed-off-by: Shu0T1an ChenG <[email protected]>
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
Add telemetry service to the list of services to stop/reset-failed/restart during config load/reload operations.
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
This is to get a better JUnitXML file and align all
the tests under the same level of hierarchy.

Signed-off-by: Shu0T1an ChenG <[email protected]>
jianyuewu pushed a commit to jianyuewu/sonic-swss that referenced this pull request Dec 24, 2025
* add more ha appl state table name

* same table name for npu/dpu

* address comment

---------

Co-authored-by: Saikrishna Arcot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants