[warm restart assist] assume vector values could be reordered

[yxieca]

What I did

When comparing 2 vectors, assume their elements could be re-ordered.

Signed-off-by: Ying Xie [email protected]

Why I did it
Without he change, during warm reboot, some neighbor entries will be mistakenly judged as having new value and recreated.

How I verified it
With the change, no neighbor entry got recreated due to having 'new value' after warm reboot.

[jipanyang]

I would recommend switching to producerstatetabe view comparison mechanism as that being used in teamsyncd. It helps to reduce the maintenance effort, also producerstatetabe view comparison mechanism is more flexible.

[yxieca]

@jipanyang can you point me to an example? I need to get the problem under control first. Can we move on then improve?

[yxieca]

@jipanyang I found the code you are talking about. This code is not generic, it is written for team management only. There needs to have some refactoring and abstracting before it can be generally in other cases. Right? And the comparison is similar to what I added here too.

[jipanyang]

@jipanyang can you point me to an example? I need to get the problem under control first. Can we move on then improve?

View switch design and implementation:
https://github.com/Azure/SONiC/blob/master/doc/warm-reboot/view_switch.md
sonic-net/sonic-swss-common#247

Usage example:
#725

We found view switch mechanism is able to handle FV vectors with non-ordered and variable number of fields.
Not sure about 210811 branch, but for master branch I think we should move to view switch mechanism.