[orchagent] PFC WD support for BFN platform#916
Conversation
|
@vsenchyshyn add a comment "retest this please" can trigger a new build and test chain. We do not need to create a new pr |
Wow interesting trick! Thanks a bunch! |
|
Also you do not need to create a separate pr specifically for 20181130 image. There is a label in the label section called "request in 20181130 image". Just add it to your original pr to mark the necessity for 1130 inclusive. Maintainer will pick it up later once it is merged to master |
stcheng
left a comment
stcheng
left a comment
There was a problem hiding this comment.
could you correct the commit title name to orchagent?
vsenchyshyn
changed the title
Signed-off-by: Vitaliy Senchyshyn <vsenchyshyn@barefootnetworks.com>
vsenchyshyn
force-pushed
the
bfn-pfc-wd-support-201811
branch
from
c74ae44 to
e9f43a4
Compare
Done! |
| (occupancy_bytes == 0 and packets - packets_last == 0 and (pfc_duration - pfc_duration_last) > poll_time * 0.8) then | ||
| if time_left <= poll_time then | ||
| redis.call('HDEL', counters_table_name .. ':' .. port_id, pfc_rx_pkt_key .. '_last') | ||
| redis.call('HDEL', counters_table_name .. ':' .. port_id, pfc_duration_key .. '_last') |
There was a problem hiding this comment.
My comments stay the same as earlier. Drop lines 74 & 75 if there is no proof that bfn has double storm signaling problem.
| if is_deadlock == false then | ||
| redis.call('HSET', counters_table_name .. ':' .. port_id, pfc_rx_pkt_key .. '_last', pfc_rx_packets) | ||
| redis.call('HSET', counters_table_name .. ':' .. port_id, pfc_duration_key .. '_last', pfc_duration) | ||
| end |
There was a problem hiding this comment.
Drop the 'if is_deadlock == false' condition. Lines 93 - 96
This is to revert the change to the reboot command in 7105400. Platform reboot is not supported by the kdump kernel, as the platform drivers are not loaded. With the existing code, there are some error messages printed, but the device is still rebooted by CPU. The change here helps to avoid the error messages.
5 participants
What I did
This is a clone of this PR: #823 for 201811
Why I did it
How I verified it
pfc_wd community test on barefoot platform passed.
Details if related