Add buffer pool watermark support#853
Merged
wendani merged 16 commits intosonic-net:masterfrom Jun 14, 2019
Merged
Conversation
a BufferOrch object: "POLL_INTERVAL" "BUFFER_POLL_PLUGIN_LIST" "STATS_MODE" Signed-off-by: Wenda Ni <wenni@microsoft.com>
…d del of its oid Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Contributor
Author
|
@mykolaf for review |
qiluo-msft
reviewed
Apr 23, 2019
qiluo-msft
reviewed
Apr 23, 2019
qiluo-msft
reviewed
Apr 23, 2019
mykolaf
reviewed
Apr 24, 2019
Signed-off-by: Wenda Ni <wenni@microsoft.com>
qiluo-msft
reviewed
Jun 12, 2019
Signed-off-by: Wenda Ni <wenni@microsoft.com>
qiluo-msft
approved these changes
Jun 12, 2019
Contributor
Author
|
retest this please |
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* Write fields to FLEX_COUNTER_GROUP_TABLE at the construction of a BufferOrch object: "POLL_INTERVAL" "BUFFER_POLL_PLUGIN_LIST" "STATS_MODE" Signed-off-by: Wenda Ni <wenni@microsoft.com> * Update buffer pool name to oid mapping in COUNTERS_DB upon the set and del of its oid Signed-off-by: Wenda Ni <wenni@microsoft.com> * Push buffer pool watermark COUNTER_ID_LIST to FLEX_COUNTER_TABLE Signed-off-by: Wenda Ni <wenni@microsoft.com> * Implement user clear logic to buffer pool watermark Signed-off-by: Wenda Ni <wenni@microsoft.com> * Add periodic clear to buffer pool watermark Signed-off-by: Wenda Ni <wenni@microsoft.com> * Add lua script for watermark_bufferpool Signed-off-by: Wenda Ni <wenni@microsoft.com> * Fix syntax error in buffer pool watermark lua script Signed-off-by: Wenda Ni <wenni@microsoft.com> * Fix compile error in watermarkorch.cpp Signed-off-by: Wenda Ni <wenni@microsoft.com> * Fix from dut verification Signed-off-by: Wenda Ni <wenni@microsoft.com> * Add 6000 to read only polling mode Signed-off-by: Wenda Ni <wenni@microsoft.com> * Touch-up to existing codes Signed-off-by: Wenda Ni <wenni@microsoft.com> * Remove debugging symbols Signed-off-by: Wenda Ni <wenni@microsoft.com> * Address comments Signed-off-by: Wenda Ni <wenni@microsoft.com> * Address comments Signed-off-by: Wenda Ni <wenni@microsoft.com>
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
…aces (sonic-net#853) libswsscommon depends on libyang deb. libyang is deprecated in bookworm. This wouldn't be a problem for buildimage because libyang is compiled from source in buildimage. However, this is causing a problem in upgrading one of our app-extensions to bookworm. This app-extension is built separately and not part of buildimage infra. Thus provide a build flag to disable compilation of libyang dependent interfaces such as DecoratorTable etc. Please note, there is no change in the default behavior vkarri@6c5cda5d64fa:/sonic/src/sonic-swss-common$ debuild -b -us -uc -Pnopython2,noyangmod vkarri@6c5cda5d64fa:/sonic/src$ sudo dpkg -i libswsscommon_1.0.0_amd64.deb vkarri@6c5cda5d64fa:/sonic/src$ sudo dpkg -i python3-swsscommon_1.0.0_amd64.deb vkarri@6c5cda5d64fa:/sonic/src$ python3 -c "from swsscommon.swsscommon import DecoratorSubscriberStateTable, DecoratorTable, YangDefaultDecorator" Traceback (most recent call last): File "<string>", line 1, in <module> ImportError: cannot import name 'DecoratorSubscriberStateTable' from 'swsscommon.swsscommon' (/usr/lib/python3/dist-packages/swsscommon/swsscommon.py) vkarri@6c5cda5d64fa:/sonic/src$ python3 -c "from swsscommon.swsscommon import DecoratorTable, YangDefaultDecorator" Traceback (most recent call last): File "<string>", line 1, in <module> ImportError: cannot import name 'DecoratorTable' from 'swsscommon.swsscommon' (/usr/lib/python3/dist-packages/swsscommon/swsscommon.py) vkarri@6c5cda5d64fa:/sonic/src$ python3 -c "from swsscommon.swsscommon import YangDefaultDecorator" Traceback (most recent call last): File "<string>", line 1, in <module> ImportError: cannot import name 'YangDefaultDecorator' from 'swsscommon.swsscommon' (/usr/lib/python3/dist-packages/swsscommon/swsscommon.py) vkarri@6c5cda5d64fa:/sonic/src$ python3 -c "from swsscommon.swsscommon import SubscriberStateTable, ProducerStateTable, Table, DBConnector" <Default Behavior> vkarri@6c5cda5d64fa:/sonic$ make -f slave.mk target/debs/bookworm/python3-swsscommon_1.0.0_amd64.deb-install vkarri@6c5cda5d64fa:/sonic$ python3 -c "from swsscommon.swsscommon import DecoratorSubscriberStateTable, DecoratorTable, YangDefaultDecorator" vkarri@6c5cda5d64fa:/sonic$ Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write fields to FLEX_COUNTER_GROUP_TABLE at the construction of a BufferOrch object:
"POLL_INTERVAL"
"BUFFER_POLL_PLUGIN_LIST"
"STATS_MODE"
Update buffer pool name to oid mapping in COUNTERS_DB upon the set and del of its oid
Push buffer pool watermark COUNTER_ID_LIST to FLEX_COUNTER_TABLE
Implement user clear logic to buffer pool watermark
Add periodic clear to buffer pool watermark
Add lua script for watermark_bufferpool
What I did
Why I did it
How I verified it
On brcm dut
Details if related
Depend on:
sonic-net/sonic-swss-common#272 Add schema for buffer pool watermark
sonic-net/sonic-buildimage#2818 Feed device info to orchagent process
Alongside:
sonic-net/sonic-sairedis#451 Add buffer pool stat to flex counter architecture
Downstream changes:
sonic-net/sonic-utilities#521 Add buffer pool watermark support in watermarkstat and counterpoll
syncd rpc support:
opencomputeproject/SAI#949