[fpmsyncd] Improve VNET routes support#838
Merged
prsunny merged 3 commits intosonic-net:masterfrom Apr 19, 2019
baiwei0427:master
Merged
[fpmsyncd] Improve VNET routes support#838prsunny merged 3 commits intosonic-net:masterfrom baiwei0427:master
prsunny merged 3 commits intosonic-net:masterfrom
baiwei0427:master
Conversation
prsunny
reviewed
Apr 15, 2019
fpmsyncd/routesync.cpp
Outdated
| using namespace swss; | ||
|
|
||
| #define VXLAN_IF_NAME_PREFIX "brvxlan" | ||
| #define VXLAN_BR_NAME_PREFIX "Brvxlan" |
Collaborator
There was a problem hiding this comment.
I think, we can retain the old name VXLAN_IF_NAME_PREFIX. I don't think we need to provide "BR" information to definition. This could be implementation specific.
Contributor
Author
There was a problem hiding this comment.
I use VXLAN_BR_NAME_PREFIX in consistent with vxlanmgrd (https://github.com/Azure/sonic-swss/blob/8a1f67f0510cdb13641bf538cbfdcd1d6be043dc/cfgmgr/vxlanmgr.cpp#L24).
Contributor
Author
There was a problem hiding this comment.
@prsunny I have changed the name back to VXLAN_IF_NAME_PREFIX
fpmsyncd/routesync.cpp
Outdated
| onVnetRouteMsg(nlmsg_type, obj); | ||
| } | ||
| onRouteMsg(nlmsg_type, obj); | ||
| } |
Collaborator
There was a problem hiding this comment.
You can remove the extra space here
Collaborator
|
retest this please |
prsunny
approved these changes
Apr 19, 2019
Contributor
|
you could remove the extra empty trailing spaces as well |
Contributor
|
This change causes fpmsyncd being OOM killed all the time on vsonic testbed. Further check shows the problem was firs introduced with #772 Now bool RouteSync::getIfName(int if_index, char *if_name, size_t name_len) is used for regular route too, it has netlink memory leak. |
Contributor
Author
|
@jipanyang I am fixing it now. You can check the PR #864 |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
What I did The feature allows setting 'detection_time', 'restoration_time' and 'pollling_interval' PFCWD to an interface. The 'pollling_interval' must be lower than 'detection_time' and 'restoration_time'. The fix is checking if there is a lower value of 'detection_time' or 'restoration_time' than the 'pollling_interval' value entered by the user in config DB, if yes exit with error code 1. How I did it Checking the config DB for interfaces PFCWD values. How to verify it Try adding 'pollling_interval' greater than one of the values of PFCWD interfaces. Previous command output (if the output of a command-line utility has changed) No Output. New command output (if the output of a command-line utility has changed) unable to use polling_interval = #ms, value is bigger or equal to the minimum in PFCWD table
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
With this feature libsairedis will have ability to act as a client and server, for example as client (pbhorch) can connect to existing server (OA) and call SAI api in server scope. Client connects over zmq channel and can be running in separate docker, connecting over ipc pipe or tcp.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* Classify routes based on the name of the master device * Remove extra space * Change marco name
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
#### Why I did it Add support of 'with' statement to ConfigDBConnector #### How I did it Add __enter__ and __exit__ method to ConfigDBConnector ##### Work item tracking - Microsoft ADO: 24222755 #### How to verify it Pass all UT and E2E test cases. Add new UT to check ConfigDBConnector support 'with' statement #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 #### Description for the changelog Add support of 'with' statement to ConfigDBConnector #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/SONiC/wiki/Configuration. --> #### A picture of a cute animal (not mandatory but encouraged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fpmsyncd: Improve VNET routes support
Pending items:
Signed-off-by: Wei Bai [email protected]