Skip to content

[orchagent]: Cast enum class variable to int#819

Merged
lguohan merged 1 commit intosonic-net:masterfrom
stcheng:cast
Mar 28, 2019
Merged

[orchagent]: Cast enum class variable to int#819
lguohan merged 1 commit intosonic-net:masterfrom
stcheng:cast

Conversation

@stcheng
Copy link
Contributor

@stcheng stcheng commented Mar 25, 2019

Signed-off-by: Shu0T1an ChenG shuche@microsoft.com

vxlanorch.cpp: In function 'sai_object_id_t create_tunnel_map(MAP_T)':
/usr/include/swss/logger.h:15:143: error: format '%d' expects argument of type 'int', but argument 5 has type 'MAP_T' [-Werror=format=]
 #define SWSS_LOG_ERROR(MSG, ...)       swss::Logger::getInstance().write(swss::Logger::SWSS_ERROR,  ":- %s: " MSG, __FUNCTION__, ##__VA_ARGS__)
                                                                                                                                               ^
vxlanorch.cpp:85:9: note: in expansion of macro 'SWSS_LOG_ERROR'
         SWSS_LOG_ERROR("Invalid map type %d", map_t);
         ^~~~~~~~~~~~~~

vnetorch.cpp: In member function 'bool VNetVrfObject::createObj(std::vector<_sai_attribute_t>&)':
/usr/include/swss/logger.h:19:143: error: format '%d' expects argument of type 'int', but argument 5 has type 'VR_TYPE' [-Werror=format=]
 #define SWSS_LOG_DEBUG(MSG, ...)       swss::Logger::getInstance().write(swss::Logger::SWSS_DEBUG,  ":- %s: " MSG, __FUNCTION__, ##__VA_ARGS__)
                                                                                                                                               ^
vnetorch.cpp:98:13: note: in expansion of macro 'SWSS_LOG_DEBUG'
             SWSS_LOG_DEBUG("VNET vr_type %d router id %lx  ", vr_type, router_id);
             ^~~~~~~~~~~~~~

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
@stcheng
Copy link
Contributor Author

stcheng commented Mar 25, 2019

This is triggered when building with stretch

@lguohan
Copy link
Contributor

lguohan commented Mar 26, 2019

retest this please

@stcheng
Copy link
Contributor Author

stcheng commented Mar 26, 2019

W: Failed to fetch http://debian-archive.trafficmanager.net/debian/dists/jessie-backports/main/binary-amd64/Packages  404  Not Found [IP: 52.247.210.153 80]
W: Failed to fetch http://debian-archive.trafficmanager.net/debian/dists/jessie-backports/contrib/binary-amd64/Packages  404  Not Found [IP: 52.247.210.153 80]
W: Failed to fetch http://debian-archive.trafficmanager.net/debian/dists/jessie-backports/non-free/binary-amd64/Packages  404  Not Found [IP: 52.247.210.153 80]

@stcheng stcheng requested a review from jleveque March 26, 2019 01:32
@lguohan
Copy link
Contributor

lguohan commented Mar 28, 2019

retest this please

@lguohan lguohan merged commit 60a8a0d into sonic-net:master Mar 28, 2019
@stcheng stcheng deleted the cast branch March 28, 2019 19:53
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
…onic-net#819)

* [reboot] make sure the reboot happens even if platform reboot failed

Platform reboot tool could fail if the platform driver didn't load
properly. In this case, a reboot is required to recover the device.
We need to make sure the reboot tool is robust.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* Rewording

* add log message
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
…s. (sonic-net#819)

Why I did:
Swss debian package used in VS docker is not the same artifact as generated by Azure pipeline
Compared md5sum of binaries of Azure artifact swss debian package and the one running in VS docker and they are not matching.

How I did:
To fix this doing explicit purge all packages before re-installing.
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
jianyuewu pushed a commit to jianyuewu/sonic-swss that referenced this pull request Dec 24, 2025
…ic-net#819)

This reverts commit 2365fe8.

Will be creating new PR to solve issue with proper RC instead of simply dropping message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants