[portsorch]: add support to set mac-address learning attribute on bridge-port#809
Conversation
pull from origin
Signed-off-by: shine.chen <[email protected]>
shine4chen
changed the title
|
learning mode can also be supported in lag, but it looks like the code here does not consider that scenario. |
Lag is also supported, please see the function PortsOrch::doLagTask(Consumer &consumer). Thinks. |
|
Learning mode has been supported in lag, but the corresponding vs-test requires lag-name-oid-map. PR#885 will provide support for lag-name-oid-map, so the vs-test code can only be provided after its modification is completed. |
stcheng
left a comment
stcheng
left a comment
There was a problem hiding this comment.
please also add unit tests. thanks!
Signed-off-by: leo.li <[email protected]>
|
The vstest has been added, please review. Thanks! |
Signed-off-by: shine.chen <[email protected]>
…/sonic-swss into bridge-port-mac-learn
|
@stcheng we has refined code according to your suggestion. Pls review thanks. |
Signed-off-by: shine.chen <[email protected]>
lisahnguyen
left a comment
lisahnguyen
left a comment
There was a problem hiding this comment.
@shine4chen: thanks for addressing my review comment.
gitsabari
left a comment
gitsabari
left a comment
There was a problem hiding this comment.
thanks for taking care of review comments
|
retest this please |
shine4chen
force-pushed
the
bridge-port-mac-learn
branch
2 times, most recently
from
32416e3 to
53a3f1e
Compare
shine4chen
force-pushed
the
bridge-port-mac-learn
branch
from
53a3f1e to
92100be
Compare
Introduce `gbsyncdmgrd`, which will be responsible for spawning and watching all gearbox syncd processes. `gbsyncdmgrd` is intended to supplant `gbsyncd_startup.py`. But until all references have been updated, we keep both, and I have added a deprecation warning to `gbsyncd_startup.py`.
…dge-port (sonic-net#809) * add support to set mac-address learning attribute on bridge-port Signed-off-by: shine.chen <[email protected]>
…-net#809) In the previous implementation, the private member variable, len, will store the error code of redisFormat. This PR is for fixing that if the redisFormat raise an unexpected error code, the `len` will be assigned to zero.
7 participants
What I did
add support to set mac-address learning attribute on bridge-port
Why I did it
Mclag feature need this. And it is common attribute for bridge-port.
How I verified it
compile and test on nephos lab
Details if related