Remove try/catch for correct coredump file#790
Merged
stcheng merged 2 commits intosonic-net:masterfrom Jun 5, 2019
Merged
Conversation
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
Collaborator
|
@qiluo-msft has fixed an issue with stack trace during orchagent crash. Request @qiluo-msft to review this. |
Contributor
|
Could you elaborate or give an example of below observation?
I believe it is a bug and we should fix it. |
Contributor
|
Can we define a function like |
qiluo-msft
approved these changes
Jun 4, 2019
stcheng
reviewed
Jun 4, 2019
|
|
||
| auto orchDaemon = make_shared<OrchDaemon>(&appl_db, &config_db, &state_db); | ||
|
|
||
| try |
Contributor
There was a problem hiding this comment.
could you also remove the try bracket and the extra indentation as well?
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
stcheng
approved these changes
Jun 5, 2019
yxieca
pushed a commit
that referenced
this pull request
Sep 23, 2019
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Reduce log level of redis channel 'wait' to debug
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jipan Yang jipan.yang@alibaba-inc.com
What I did
This is a try to work around the coredump create issue: #734
Why I did it
How I verified it
core dump with right stack trace created.
Details if related
Actually It might be caused by incorrect destruct of multiple orch ( inter-dependency, order and etc.), which triggered more segmentation during try/catch stack unwinding, then only the latest segfault got recorded.
If people have idea about how to fix the possible orch destruct issue, that would be better.