Skip to content

Increase the watermark polling interval to 10s#777

Merged
lguohan merged 3 commits intosonic-net:masterfrom
wendani:wm_poll_interval
Feb 2, 2019
Merged

Increase the watermark polling interval to 10s#777
lguohan merged 3 commits intosonic-net:masterfrom
wendani:wm_poll_interval

Conversation

@wendani
Copy link
Copy Markdown
Contributor

@wendani wendani commented Jan 31, 2019

Signed-off-by: Wenda [email protected]

What I did

Why I did it
Observe high CPU utilization when watermark polling is enabled with 1s polling interval. Lower the polling resolution to 10s. May reduce the interval later if there will be efforts to improve the watermark read and clear path.

How I verified it

Details if related

@wendani wendani requested a review from stcheng January 31, 2019 18:24
@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Jan 31, 2019

Suggest to provide more details in description especially here for "why I did this" since you now change from 1 sec to 10 sec and what issues were observed with 1sec. This would be good for any future reference

@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Jan 31, 2019

I think you need to fix the watermark test (timing) since you changed the timer.

@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Feb 1, 2019

retest this please

@lguohan lguohan merged commit 73b620c into sonic-net:master Feb 2, 2019
@yxieca
Copy link
Copy Markdown
Contributor

yxieca commented Feb 5, 2019

Made to 201811 branch on 2/4/2019

yxieca pushed a commit that referenced this pull request Feb 5, 2019
* Increase the watermark polling interval to 10s

Signed-off-by: Wenda <[email protected]>

* Update watermark test timing with 10s polling interval

Signed-off-by: Wenda <[email protected]>
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
Add a "show platform fanstatus" command to allow user fetch FAN status data.
Add a "show platform temperature" command to allow user fetch thermal status data.
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
…ic-net#777)

This commit fixes a syncd crash seen when running the sonic-mgmt comunity test
suites against the Marvell armhf platform. Analysis of the generated core file
points to improper format specifiers used when writing SWSS log entries. This
commit fixes that.
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
* Increase the watermark polling interval to 10s

Signed-off-by: Wenda <[email protected]>

* Update watermark test timing with 10s polling interval

Signed-off-by: Wenda <[email protected]>
jianyuewu pushed a commit to jianyuewu/sonic-swss that referenced this pull request Dec 24, 2025
* Flexcounter macros are defined
* Statistics capability get lua script updated with new Capability API support

Signed-off-by: rpmarvell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants