Support ConfigDB neighbor configuration, introduce nbrmgr daemon#693
Merged
prsunny merged 6 commits intosonic-net:masterfrom Nov 28, 2018
Merged
Support ConfigDB neighbor configuration, introduce nbrmgr daemon#693prsunny merged 6 commits intosonic-net:masterfrom
prsunny merged 6 commits intosonic-net:masterfrom
Conversation
This was referenced Nov 16, 2018
Contributor
pavel-shirshov
left a comment
There was a problem hiding this comment.
Is it possible to use libnl3 for netlink programming?
jipanyang
reviewed
Nov 20, 2018
Contributor
jipanyang
left a comment
There was a problem hiding this comment.
In the case of mac address of the neighbor is empty, how would neighmgr handle warm restart/warm reboot scenarios? Some cooperation with neighsyncd seems necessary.
pavel-shirshov
approved these changes
Nov 21, 2018
Contributor
pavel-shirshov
left a comment
There was a problem hiding this comment.
Approve from my side. Please check Jipans' comments
Collaborator
Author
|
@jipanyang, as mentioned in description, plan is to merge neighsyncd and neighbor manager in next phase. I'll consider the warm-restart scenarios along with that. For the current use-case, we can skip the warm-restart requirements. |
lguohan
approved these changes
Nov 27, 2018
jipanyang
approved these changes
Nov 28, 2018
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
* Per-switching silicon Common config for Broadcom Supported Platforms.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…ic-net#693) * Introduce neighbor manager daemon * Corrected the ConfigDB name * Modified to use libnl3, address review comments * Retain nl socket after use, address review comments * Check invalid mac configuration, catch exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Initial commit to support ConfigDB neighbor table configurations
Why I did it
Requirement to resolve mac address for a configured neighbor IP. Also support static neighbor configuration
How I verified it
Logs:
Resolve case:
Static Nbr:
Details if related
This is the initial commit for phase 1.
For phase 2: