[orchagent][copp] default trap group support#68
Merged
stcheng merged 1 commit intosonic-net:masterfrom Sep 3, 2016
Merged
Conversation
orchagent/copporch.cpp
Outdated
| sai_status_t sai_status; | ||
| sai_attribute_t attrib; | ||
|
|
||
| if (m_trap_group_map.find(default_trap_group) != m_trap_group_map.end()) { |
Contributor
|
Pleaese remove the init in the portsorch.cpp |
orchagent/copporch.cpp
Outdated
| catch(const std::out_of_range e) | ||
| { | ||
| SWSS_LOG_ERROR("processing copp rule threw exception:%s", e.what()); | ||
| SWSS_LOG_ERROR("processing copp rule threw exception:%s, line:%s", e.what(), __LINE__); |
Contributor
There was a problem hiding this comment.
@hrachya-mellanox ,please address kamil's comments in your previous pull request.
hrachya-m
force-pushed
the
copp.default.trap.gorup
branch
from
a04baf8 to
e32f6e1
Compare
| @@ -10,6 +10,8 @@ using namespace swss; | |||
|
|
|||
Contributor
There was a problem hiding this comment.
using namespace std;
and remove all the std:: in .cpp file to align with all other files.
Contributor
|
🕐 |
hrachya-m
force-pushed
the
copp.default.trap.gorup
branch
from
e32f6e1 to
6f6f253
Compare
orchagent/copporch.cpp
Outdated
|
|
||
| sai_attribute_t attr; | ||
| vector<sai_attribute_t> trap_id_attrs; | ||
| vector<sai_hostif_trap_id_t> default_trap_ids = { |
Contributor
There was a problem hiding this comment.
move this default_trap_ids to below the const string default_trap_group as a const.
* Default trap group should be referenced with name 'default' in the configuration json file. * Create policer and attach to default trap group * Initialize ttl_error with TRAP action belonging to default trap group.
hrachya-m
force-pushed
the
copp.default.trap.gorup
branch
from
6f6f253 to
bce1f66
Compare
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
lukasstockner
pushed a commit
to genesiscloud/sonic-swss
that referenced
this pull request
Apr 2, 2023
DavidZagury
pushed a commit
to DavidZagury/sonic-swss
that referenced
this pull request
Apr 28, 2025
<!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** Fix a typo. The current word is "high ber_error", but the correct word should be "high_ber_error" **Why I did it** Fix a typo **How I verified it** unit test **Details if related**
liuh-80
pushed a commit
to liuh-80/sonic-swss
that referenced
this pull request
Jun 10, 2025
…into 202503 sonic-net#73 Merge branch '202412' of https://github.com/sonic-net/sonic-swss.msft into 202503 Merge from 202412. 9c96d25 Initialize the last fec ber computed values if not found (sonic-net#71) b567ab5 Merge pull request sonic-net#70 from mssonicbld/sonicbld/202412-merge 19ed87b Merge branch '202411' of https://github.com/sonic-net/sonic-swss into 202412 4383d39 Fix the missed port status notifications issue (sonic-net#3616) 4f6d557 Merge pull request sonic-net#69 from r12f/user/r12f/fix-build fcbe392 Revert "Merge branch '202411' of https://github.com/sonic-net/sonic-swss into 202412" 9e9442d [orchagent] Fix issue: typo in high BER (sonic-net#68) 7498ae9 Merge pull request sonic-net#67 from mssonicbld/sonicbld/202412-merge bbce4b4 Merge branch '202411' of https://github.com/sonic-net/sonic-swss into 202412 9e97862 Merge pull request sonic-net#66 from mssonicbld/sonicbld/202412-merge fceb196 Revert "Optimize counter polling interval by making it more accurate 5206c2b Merge branch '202411' of https://github.com/sonic-net/sonic-swss into 202412 d88b694 Remove unused string variables in flexcounterorch.cpp 1e4315e Remove unused string variables in flexcounterorch.cpp e82f8c2 Revert "Optimize counter polling interval by making it more accurate (sonic-net#3500)" ca017d0 [vstest]: Fix MACsec test in the kernel 5.15 (sonic-net#3573)
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signed-off-by [email protected]