Skip to content

VNET/VXLAN changes#643

Merged
prsunny merged 10 commits intosonic-net:masterfrom
prsunny:master
Nov 26, 2018
Merged

VNET/VXLAN changes#643
prsunny merged 10 commits intosonic-net:masterfrom
prsunny:master

Conversation

@prsunny
Copy link
Copy Markdown
Collaborator

@prsunny prsunny commented Oct 16, 2018

What I did
Modified Vxlanorch to support VNet peering feature.
Introduced the following:

  1. Vxlan VRF mapper
  2. Generic code to handle BRIDGE/VRF/VLAN encap/decap mapper
  3. Test case update for existing Vxlan VS test.

Why I did it
Support VNet peering using Vxlan (VNI <-> VRF)

How I verified it
Verified by VS test and checking the ASIC DB for intended SAI tables

Details if related
Design Document:
https://github.com/prsunny/SONiC/blob/gh-pages/doc/vxlan/Vxlan_hld.md
Related PR
#632

Pending:

  1. VS test case for VNET (new code)
  2. Delete sequence.

@prsunny
Copy link
Copy Markdown
Collaborator Author

prsunny commented Oct 17, 2018

retest this please

@prsunny prsunny closed this Oct 17, 2018
@prsunny prsunny reopened this Oct 17, 2018
@sonic-net sonic-net deleted a comment from qiluo-msft Oct 22, 2018
@prsunny
Copy link
Copy Markdown
Collaborator Author

prsunny commented Oct 22, 2018

retest this please

@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Oct 22, 2018

@prsunny , can you rebase your pr and do a test again? I fixed a few things on the vstest.

@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Oct 23, 2018

retest this please

lguohan
lguohan reviewed Oct 26, 2018
View reviewed changes
lguohan
lguohan reviewed Oct 26, 2018
View reviewed changes
lguohan
lguohan reviewed Oct 26, 2018
View reviewed changes
lguohan
lguohan reviewed Oct 26, 2018
View reviewed changes
@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Oct 26, 2018

is the vs test in this PR or a new PR?

lguohan
lguohan reviewed Oct 26, 2018
View reviewed changes
lguohan
lguohan reviewed Oct 26, 2018
View reviewed changes
lguohan
lguohan reviewed Oct 26, 2018
View reviewed changes
lguohan
lguohan reviewed Oct 30, 2018
View reviewed changes
lguohan
lguohan reviewed Oct 30, 2018
View reviewed changes
lguohan
lguohan reviewed Oct 30, 2018
View reviewed changes
lguohan
lguohan reviewed Oct 30, 2018
View reviewed changes
lguohan
lguohan requested changes Oct 30, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactor test cases to make it more readable.

pavel-shirshov
pavel-shirshov suggested changes Nov 1, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@pavel-shirshov pavel-shirshov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

@pavel-shirshov
Copy link
Copy Markdown
Contributor

pavel-shirshov commented Nov 5, 2018

I see two functions with the same name, but with different signatures. If you need both functions I'd suggest to change names, otherwise you'd better to remove unused one.

sai_object_id_t create_tunnel_map_entry(
    MAP_T map_t,
    sai_object_id_t tunnel_map_id,
    sai_object_id_t obj_id,
    sai_uint32_t vni,
    bool encap)

vs

static sai_object_id_t
create_tunnel_map_entry(
    MAP_T map_t,
    sai_object_id_t tunnel_map_id,
    sai_uint32_t vni,
    sai_uint16_t vlan_id)

@prsunny
Copy link
Copy Markdown
Collaborator Author

prsunny commented Nov 9, 2018

@pavel-shirshov , addressed the comment by combining the two APIs. Initially thought to leave the existing function unmodified.

There are new changes to the PR based on VNET Table flow redesign. The new flow is updated in the HLD document.

jipanyang
jipanyang reviewed Nov 20, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@jipanyang jipanyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you updated Application DB schema with VXLAN_TUNNEL_MAP in swss-schema.md?

@prsunny prsunny merged commit bffa01f into sonic-net:master Nov 26, 2018
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
@rajkumar38
[syncd] ARM32 bit fixes, for 64bit printf format specifier. (sonic-ne…
8d3ae8c 
…t#643)

* [syncd] ARM32 bit fixes, for 64bit printf format specifier.

Signed-off-by: Rajkumar Pennadam Ramamoorthy <[email protected]>

* [syncd] ARM32 bit fixes, for 64bit printf format specifier.

Signed-off-by: Rajkumar Pennadam Ramamoorthy <[email protected]>
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
@prsunny
VNET/VXLAN changes (sonic-net#643)
bd1d93d 
* Vnetvxlan changes

* VS test case for Vnet/Vxlan

* Addressed review comments, fixed a VS test case

* Modifications based on feedback for VNET Table flow, VS test restructure to adopt to new changes

* Schema updated for App DB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan approved these changes

@marian-pritsak marian-pritsak marian-pritsak approved these changes

+2 more reviewers

@pavel-shirshov pavel-shirshov pavel-shirshov approved these changes

@jipanyang jipanyang jipanyang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement ➕

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@prsunny @lguohan @pavel-shirshov @marian-pritsak @jipanyang @stcheng