Merged
Conversation
added 3 commits
August 10, 2018 16:23
Signed-off-by: Stepan Blyschak <[email protected]>
After tunnel removal there was still overlay loopback interface in ASIC DB. Signed-off-by: Stepan Blyschak <[email protected]>
Seperate symmetric and decap tunnel test Add checks for tunnel removal Signed-off-by: Stepan Blyschak <[email protected]>
|
@sihuihan88 can you please review and validate? once done please merge |
sihuihan88
approved these changes
Aug 16, 2018
Contributor
|
Ansible decap test doesn't include ipv6 from my understanding. Can you also add that test? |
Contributor
Author
|
@sihuihan88 Please check sonic-net/sonic-mgmt#682. |
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* Allow decap tunnel configuration without "src_ip" Signed-off-by: Stepan Blyschak <[email protected]> * Remove overlay loopback interface when removing tunnel After tunnel removal there was still overlay loopback interface in ASIC DB. Signed-off-by: Stepan Blyschak <[email protected]> * Add more test cases to test_tunnel.py Seperate symmetric and decap tunnel test Add checks for tunnel removal Signed-off-by: Stepan Blyschak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
Couldn't create a decap tunnel without "src_ip" field, also there is no need to specify "src_ip" for decap only tunnel
After tunnel deletion, created overlay interface still exists, so I fixed that
How I verified it
Details if related
When trying to create tunnel without "src_ip":
[ { "TUNNEL_DECAP_TABLE:IPINIP_V4_TUNNEL" : { "tunnel_type":"IPINIP", "dst_ip":"1.1.1.1", "dscp_mode":"uniform", "ecn_mode":"standard", "ttl_mode":"pipe" }, "OP": "SET" } ]I got orchagent crash:
Aug 10 13:28:53.819634 arc-switch1041 NOTICE swss/swssconfig: :- main: Loading config from JSON file:a.json...Aug 10 13:28:53.822425 arc-switch1041 NOTICE swss/orchagent: :- addDecapTunnel: Create overlay loopback router interface oid:600000000072cAug 10 13:28:53.822587 arc-switch1041 INFO syncd/supervisord: syncd Aug 10 13:28:53 NOTICE SAI_RIF: mlnx_sai_rif.c[241]- mlnx_create_router_interface: Create rif, #0 VIRTUAL_ROUTER_ID=VIRTUAL_ROUTER,(0:0),0,0000,0 #1TYPE=LOOPBACKAug 10 13:28:53.823288 arc-switch1041 ERR swss/orchagent: :- main: Failed due to exception: basic_string::_S_construct null not validAug 10 13:28:53.823532 arc-switch1041 INFO kernel: [ 9199.294165] orchagent[14187]: segfault at 8 ip 000000000049318e sp 00007fffa351bc50 error 4 in orchagent[400000+102000]Aug 10 13:28:53.829530 arc-switch1041 INFO syncd/supervisord: syncd Aug 10 13:28:53 NOTICE SAI_RIF: mlnx_sai_rif.c[532]- mlnx_create_router_interface: Created rif rif 26Aug 10 13:28:55.576082 arc-switch1041 INFO swss.sh[13747]: 2018-08-10 13:28:55,575 INFO exited: orchagent (terminated by SIGSEGV (core dumped); not expected)Aug 10 13:28:56.491711 arc-switch1041 INFO swss/supervisord 2018-08-10 13:28:55,575 INFO exited: orchagent (terminated by SIGSEGV (core dumped); not expected)