swss: Dataplane telemetry support in SONiC by shruthi9 · Pull Request #521 · sonic-net/sonic-swss

shruthi9 · 2018-06-08T23:30:48Z

Adding dataplane telemetry configuration support in SONiC

Pending: new VS tests to be added for this feature
A separate PR will be created for new community tests that will added for this feature

Design for the feature is at:
sonic-net/SONiC#182

…heckin

enable mirror

…sence

shruthi9 · 2018-07-13T05:56:29Z

Fixed the VS test

lguohan · 2018-07-13T06:20:13Z

orchagent/orchdaemon.cpp

+    m_orchList = { switch_orch, gCrmOrch, gPortsOrch, intfs_orch, gNeighOrch, gRouteOrch, copp_orch, tunnel_decap_orch, qos_orch, gBufferOrch, mirror_orch };
+
+    bool initialize_dtel = false;
+    if (platform == BFN_PLATFORM_SUBSTRING)


in vs env, the platform is not BFN, then initialize_dtel is false and dtel_orch is not initialized, how can dtel vs test passing? Where do I miss here?

I locally remove the platform check when I run the test. Without the check, I make sure it still passes for other platforms. Is there some other way to handle platform-specific feature tests for VS?

I will add platform vs for this env, and you can check if platform == "vs" or platform == BFN_PLATFORM_SUBSTRING

lguohan · 2018-07-13T06:31:57Z

tests/test_dtel.py

+        atbl = swsscommon.Table(adb, "ASIC_STATE:SAI_OBJECT_TYPE_DTEL")
+        keys = atbl.getKeys()
+
+        for k in keys:


i see, here the keys is null then, no assert is checked, that is why it is passing.

need to assert len(keys) > 1

The check would fail if platform is not barefoot. Is there a "vs platform" check that we can add to orchdaemon.cpp to initialize dtel, in addition to barefoot?

lguohan · 2018-07-13T06:41:31Z

orchagent/orch.h


 #define MLNX_PLATFORM_SUBSTRING "mellanox"
 #define BRCM_PLATFORM_SUBSTRING "broadcom"
+#define BFN_PLATFORM_SUBSTRING  "barefoot"


add BFN_PLATFORM_SUBSTRING "vs" here.

I will export the env in the vs.

Will do. Thanks!

check here.

sonic-net/sonic-buildimage#1860

I mean #define VS_PLATFORM_SUBSTRING "vs"

lguohan · 2018-07-13T07:05:54Z

tests/test_dtel.py

+
+        atbl = swsscommon.Table(adb, "ASIC_STATE:SAI_OBJECT_TYPE_DTEL_REPORT_SESSION")
+        keys = atbl.getKeys()
+


check keys is not empty.

lguohan · 2018-07-13T07:06:05Z

tests/test_dtel.py

+        atbl = swsscommon.Table(adb, "ASIC_STATE:SAI_OBJECT_TYPE_DTEL_INT_SESSION")
+        keys = atbl.getKeys()
+
+        for k in keys:


check keys is not empty.

lguohan · 2018-07-13T07:06:11Z

tests/test_dtel.py

+        atbl = swsscommon.Table(adb, "ASIC_STATE:SAI_OBJECT_TYPE_DTEL_QUEUE_REPORT")
+        keys = atbl.getKeys()
+
+        for k in keys:


check keys is not empty.

lguohan · 2018-07-13T07:06:20Z

tests/test_dtel.py

+        atbl = swsscommon.Table(adb, "ASIC_STATE:SAI_OBJECT_TYPE_DTEL_EVENT")
+        keys = atbl.getKeys()
+
+        for k in keys:


check keys is not empty.

Dtel rev comments

shruthi9 · 2018-07-13T18:59:51Z

Enabled DTel for VS platform and fixed the test

lguohan · 2018-07-13T20:20:26Z

retest this please

shruthi9 · 2018-07-13T21:01:05Z

Looks like platform env variable is not set to "vs" and dtel test fails due to that in the newly added assert. sonic-buildimage seems to be at commit daf590e. How do we fix this to pick the latest?

shruthi9 · 2018-07-14T20:16:51Z

buildimage-vs-all build has been failing last couple of times. VS tests here are not passing because the requisite change in buildimage is not present

lguohan · 2018-07-14T23:39:19Z

platform vs is added. the dtel orch tests are passing, but it looks like it is causing mirror test to fail.

it looks like it is causing two tests to fail.

test_mirror.py::TestMirror::test_AclRuleDscpWithoutMask FAILED           [ 70%]
test_mirror.py::TestMirror::test_AclRuleDscpWithMask FAILED              [ 72%]

@shruthi9 , ca you take a look?
@stcheng , can you also take a look?

lguohan · 2018-07-15T02:40:59Z

thanks

stcheng

could you explain a little bit about my questions?

stcheng · 2018-07-20T18:36:45Z

tests/test_mirror.py


        acl_tables = [k for k in keys if k not in dvs.asicdb.default_acl_table]
-        assert len(acl_tables) == 1
+        assert len(acl_tables) >= 1


what is the exact number of the ACL tables?

DTel adds 2 additional ACL tables in addition to the default one

stcheng · 2018-07-20T18:38:03Z

tests/test_mirror.py

+        assert len(acl_tables) >= 1

-        return acl_tables[0]
+        # Filter out DTel Acl tables


If this ACL table is there by default, you could add the table information in the conftest.py file.

…onic-net#521) * Add buffer pool watermark support to watermarkstat Signed-off-by: Wenda Ni <wenni@microsoft.com> * Add buffer pool watermark to counterpoll Signed-off-by: Wenda Ni <wenni@microsoft.com> * Print N/A if the buffer pool watermark value is not present Signed-off-by: Wenda Ni <wenni@microsoft.com> * Fix syntax error; Change signature of function get_print_all_stat Signed-off-by: Wenda Ni <wenni@microsoft.com> * Address review comments Signed-off-by: Wenda Ni <wenni@microsoft.com>

* initial barefoot support october 2017 * import changes from telemetry branch * Fix merge issues w.r.t rel_6_0 branch * add validate and get port speed APIs - cleanup deletes from earlier checkin * missed changes from earlier * missed integration delete * trying to get close to master version - and not break other vendor * set the port config in the ASIC_DB * update hostif oper status besides the DB update * Fix compilation issues * merge closer to master - including spaces and comments * fix typos enable mirror * cosmetic fix * Fix errors due to saiacl.h changes * Fix more errors due to sai header file changes * fix the order of nexthop/neighbor delete * Fix compilation issues and few issues seen in testing * Changes needed to add new Dtel api support to sairedis * Report session DTel table related fixes * Add more error handling code * Fix logic to read table name and keys from m_toSync map * Update value for dtel actions * Handle boolean attributes to accept true/false as well as presence/absence * Fix merge errors * Incorporate configdb related changes for dtel * fix code merge issue * Incorporate configdb related changes for dtel * add pfc_detect lua script * Changes to incorporate new DTel SAI changes * SONiC changes due to DTel experimental SAI changes * cleanup configure.ac to allow barefoot platform includes * fix typo * revert commented tunneldecap * test selective tunneldecap * revert too ambitious an attempt and just push_back into vector! * change fec mode to string (from integer) * cleanup based on review * closer to 201712 - cosmetic cleanup * address review comments * fix format * Support for platforms based on Barefoot Networks' device (sonic-net#452) * Fix issue with "config save" followed by reboot * Temp remove crmorch Currently orchagent crashes if crm is running. Needs to be fixed * Initial code changes to address community design review comments * Temp remove crmorch Currently orchagent crashes if crm is running. Needs to be fixed P.S This is actual commit that removes crm. Previous commit was to correct a typo, and has wrong commit message * More changes to address review comments * Fix build errors * Fix for orchagent crash * Fix queue report deletion error * Bug fixes * Re-enable crm orchagent (Pterosaur#3) * Add support for new watchlist attribute to enable/disable tail drop reporting * Add new VS test for Dataplane Telemetry feature * Add support for AN and FEC to be specified in port_config.ini * do not set autoneg if it is already set * Address review comments * Fix compilation errors * set port adv speed for AN and add test Signed-off-by: Guohan Lu <gulv@microsoft.com> * Convert all the tabs to spaces * Bring in changes for port an/fec from azure master * support autoneg and fec in port config ini file * if autoneg is specified, along with speed; speed is set seperately as port attribute * Address review comments * Remove trailing whitespaces * Fix vs test indentation * Address review comments * Fix for VS test * Fix VS test failure * Fix for VS test * More VS test fixes * Fix for test_mirror VS test that was failing due to new DTel ACL tables

…onic-net#521)

kram and others added 30 commits November 2, 2017 16:58

initial barefoot support october 2017

475e2da

import changes from telemetry branch

3772494

Fix merge issues w.r.t rel_6_0 branch

5183cf2

add validate and get port speed APIs - cleanup deletes from earlier c…

4a02a6f

…heckin

Merge branch 'rel_6_0' into bf-master

9aa8377

missed changes from earlier

c78f25f

missed integration delete

56d480e

trying to get close to master version - and not break other vendor

e0cad33

set the port config in the ASIC_DB

1531771

update hostif oper status besides the DB update

0011df4

Fix compilation issues

52b553f

merge closer to master - including spaces and comments

b5f5856

fix typos

1b347a4

enable mirror

Merge branch 'rel_6_0' into rel_6_0_telemetry

c5eae16

Merge remote-tracking branch 'azure/master' into bf-master

41cff68

cosmetic fix

8c1d488

Fix errors due to saiacl.h changes

55ccc28

Fix more errors due to sai header file changes

34fa4c0

Merge remote-tracking branch 'azure/master' into bf-master

c944692

Merge remote-tracking branch 'azure/master' into bf-master

f9d4999

fix the order of nexthop/neighbor delete

2505270

Merge remote-tracking branch 'origin/rel_6_1' into bf-master

5a1db21

Fix compilation issues and few issues seen in testing

95abdfd

Changes needed to add new Dtel api support to sairedis

ac4cdda

Report session DTel table related fixes

d728c39

Add more error handling code

8b93a9d

Fix logic to read table name and keys from m_toSync map

2324da5

Update value for dtel actions

e5a9005

Handle boolean attributes to accept true/false as well as presence/ab…

07b725e

…sence

Merge remote-tracking branch 'origin/rel_6_0_telemetry' into telemetry

6c209bb

lguohan reviewed Jul 13, 2018

View reviewed changes

Address review comments

42ca6ed

lguohan reviewed Jul 13, 2018

View reviewed changes

admin12 and others added 3 commits July 13, 2018 11:50

Merge branch 'bf-master' into dtel_rev_comments

3f653dd

Fix for VS test

6a96973

Merge pull request #8 from barefootnetworks/dtel_rev_comments

f047cde

Dtel rev comments

Fix VS test failure

98f3c2b

admin12 added 2 commits July 13, 2018 14:02

Fix for VS test

ed71655

More VS test fixes

658e4a3

Shruthi Krishnan added 2 commits July 14, 2018 18:29

Merge remote-tracking branch 'azure/master' into bf-master

6f033e3

Fix for test_mirror VS test that was failing due to new DTel ACL tables

533773e

lguohan merged commit dcf6c90 into sonic-net:master Jul 15, 2018

stcheng reviewed Jul 20, 2018

View reviewed changes

stcheng added the Enhancement ➕ label Jul 20, 2018

stcheng mentioned this pull request Jul 20, 2018

[test]: Fix test_mirror with correct number of ACL tables #541

Closed

jianyuewu pushed a commit to jianyuewu/sonic-swss that referenced this pull request Dec 24, 2025

Update schema.h to include config_db DHCP and state_db counter table (s…

ef21bec

…onic-net#521)


		atbl = swsscommon.Table(adb, "ASIC_STATE:SAI_OBJECT_TYPE_DTEL_REPORT_SESSION")
		keys = atbl.getKeys()

Conversation

shruthi9 commented Jun 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shruthi9 commented Jul 13, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shruthi9 commented Jul 13, 2018

Uh oh!

lguohan commented Jul 13, 2018

Uh oh!

shruthi9 commented Jul 13, 2018

Uh oh!

shruthi9 commented Jul 14, 2018

Uh oh!

lguohan commented Jul 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lguohan commented Jul 15, 2018

Uh oh!

stcheng left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

shruthi9 commented Jun 8, 2018 •

edited

Loading

lguohan commented Jul 14, 2018 •

edited

Loading