Fix issue with update ACL TABLE CRM error#498
Closed
JaredLius wants to merge 9 commits intosonic-net:masterfrom
leoli-nps:master
Closed
Fix issue with update ACL TABLE CRM error#498JaredLius wants to merge 9 commits intosonic-net:masterfrom leoli-nps:master
JaredLius wants to merge 9 commits intosonic-net:masterfrom
leoli-nps:master
Conversation
…c configuration is blank" This reverts commit 6ce6d90.
…he fec configuration is blank
prsunny
reviewed
May 10, 2018
orchagent/portsorch.cpp
Outdated
| } | ||
|
|
||
| gCrmOrch->incCrmAclUsedCounter(CrmResourceType::CRM_ACL_GROUP, (sai_acl_stage_t) group_attr.value.s32, SAI_ACL_BIND_POINT_TYPE_PORT); | ||
| sai_acl_stage_t acl_stage = ingress ? SAI_ACL_STAGE_INGRESS : SAI_ACL_STAGE_EGRESS; |
Collaborator
There was a problem hiding this comment.
This was a bug that was fixed and merged recently. Can you check the latest code?
Contributor
Author
There was a problem hiding this comment.
I have checked the latest code on master branch, but did not see the fix code. Could you please tell me in which commit it merged? thank you.
Contributor
|
retest this please |
Contributor
|
test failure, please fix. |
…RS_PORT_NAME_MAP" This reverts commit 12e5bea.
Contributor
|
retest this please |
Contributor
|
retest this please |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* update * update * address comments * address comments * add import sys * handle request timeout
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
When sflow is configured using CLI or other supported mechanisms, the orch-agent invokes the SAI API set_port_attribute(). For the sflow feature, his API is used to set the SAI_PORT_ATTR_INGRESS_SAMPLEPACKET_ENABLE attribute of a netdev port. The value stored for this attribute is a samplepacket object, which essentially contains various sampling attributes (sampling rate, sampler group etc.) associated with the port. When sampling is disabled on a port, the SAI_PORT_ATTR_INGRESS_SAMPLEPACKET_ENABLE attribute is set to a null object. When sampling is enabled on a port, the SAI_PORT_ATTR_INGRESS_SAMPLEPACKET_ENABLE attribute is set to a valid samplepacket object. For sonic-vs, in the absence of a real ASIC programming, the 'tc' command is used instead to configure the sampling parameters inside the kernel. In this PR we invoke the appropriate 'tc' command, based on the requested config actions (disable or enable or update). Signed-off-by: Rakesh Datta <rakesh.datta@dell.com>
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
add extra parameter to linkToDbNative , which is default to "NOTICE" to allow daemons to set their own log level easily.
Example:
Logger::linkToDbNative("portsyncd"); // by default "NOTICE"
Logger::linkToDbNative("portsyncd", "INFO"); //explicit "INFO"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix issue with update ACL TABLE CRM error
Why I did it
when execute command "crm show resource all", it display wrong used count on acl_table. the ingress used acl_table was counted to egress used. from the code, when it call function gCrmOrch->incCrmAclUsedCounter, the second parameter is the acl stage, but the code use a variable attr.value.s32 which has been modified, it is not equal to acl stage any more.
How I verified it
I make a new swss_1.0.0_amd64.deb, and update it to switch. after reboot, when execute "crm show resource all", it can display the acl_table used count correctly.
Details if related