Use the refactored version of Selectables#470
Merged
pavel-shirshov merged 3 commits intosonic-net:masterfrom Apr 16, 2018
Merged
Use the refactored version of Selectables#470pavel-shirshov merged 3 commits intosonic-net:masterfrom
pavel-shirshov merged 3 commits intosonic-net:masterfrom
Conversation
pavel-shirshov
changed the title
qiluo-msft
approved these changes
Apr 16, 2018
Contributor
Author
|
retest this please |
2 similar comments
Contributor
Author
|
retest this please |
Contributor
|
retest this please |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Signed-off-by: Wenda Ni <[email protected]>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* Remove deprecated parameter from select() * Convert Selectables to new interface
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
…nic-net#470) Fix: ConfigDBConnector call super init with proper parameter name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please don't push into the master
What I did
Refactor swss to support refactored swss-common
Why I did it
Because refactored version has changed interface of Select class (fd parameter was removed from Select::select() method) and also Selectable interface was changed
How I verified it
Build new image, install it on str-s6100-acs-1 and run FR test
Details if related
This PR relies on the following PR: sonic-net/sonic-swss-common#192