fpmsyncd: Add RIB/FIB processing support#4419
Open
GaladrielZhao wants to merge 1 commit intosonic-net:masterfrom
Open
fpmsyncd: Add RIB/FIB processing support#4419GaladrielZhao wants to merge 1 commit intosonic-net:masterfrom
GaladrielZhao wants to merge 1 commit intosonic-net:masterfrom
Conversation
This commit introduces support for processing NextHopGroupFull messages with sonic-fib in fpmsyncd when RIB/FIB functionality is enabled. The implementation adds a new device metadata configuration option "nhg_fib" which can be set to "enabled" to activate the RIB/FIB feature. When this option is enabled, fpmsyncd will handle the new netlink message types RTM_NEWNHGFIB and RTM_DELNHGFIB from zebra. For decoding the NextHopGroupFull JSON data received from zebra, the code utilizes the sonic-fib library's from_json function to parse the JSON string and construct NextHopGroupFull objects. These objects are then forwarded to the NHG Manager for further processing. The route handling logic has also been adapted to work correctly when RIB/FIB is enabled. When processing routes that reference next hop groups by ID, fpmsyncd now queries the NHG Manager's RIB NHG table to retrieve the corresponding RIBNHGEntry. This allows proper mapping between zebra's NHG IDs and SONiC's internal NHG IDs, and handles both single next-hop and multi-next-hop scenarios appropriately. Signed-off-by: Yuqing Zhao <galadriel.zyq@alibaba-inc.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
This commit introduces support for processing NextHopGroupFull messages with sonic-fib in fpmsyncd when RIB/FIB functionality is enabled.
The implementation adds a new device metadata configuration option "nhg_fib" which can be set to "enabled" to activate the RIB/FIB feature. When this option is enabled, fpmsyncd will handle the new netlink message types RTM_NEWNHGFIB and RTM_DELNHGFIB from zebra.
For decoding the NextHopGroupFull JSON data received from zebra, the code utilizes the sonic-fib library's from_json function to parse the JSON string and construct NextHopGroupFull objects. These objects are then forwarded to the NHG Manager for further processing.
The route handling logic has also been adapted to work correctly when RIB/FIB is enabled. When processing routes that reference next hop groups by ID, fpmsyncd now queries the NHG Manager's RIB NHG table to retrieve the corresponding RIBNHGEntry. This allows proper mapping between zebra's NHG IDs and SONiC's internal NHG IDs, and handles both single next-hop and multi-next-hop scenarios appropriately.
Why I did it
To support for processing NextHopGroupFull messages with sonic-fib in fpmsyncd when RIB/FIB functionality is enabled.
How I verified it