Add explicitly ECN mode attributes for Dual-ToR IPinIP tunnel#4413
Open
ayurkiv-nvda wants to merge 1 commit intosonic-net:masterfrom
Open
Add explicitly ECN mode attributes for Dual-ToR IPinIP tunnel#4413ayurkiv-nvda wants to merge 1 commit intosonic-net:masterfrom
ayurkiv-nvda wants to merge 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add SAI_TUNNEL_DECAP_ECN_MODE_COPY_FROM_OUTER for SAI_TUNNEL_ATTR_DECAP_ECN_MODE
add SAI_TUNNEL_ENCAP_ECN_MODE_STANDARD for SAI_TUNNEL_ATTR_ENCAP_ECN_MODE
Why I did it
In Dual-ToR scenario we create tunnel 2 times (in tunneldecaporch and muxorch
But in muxorch we do not set ECN-related param (copy_from_outer). And since it was not set then by default we are using "standard" ECN mode.
Need to specify explicitly ECN mode for decap and encap
How I verified it
run https://github.com/sonic-net/sonic-mgmt/blob/master/tests/decap/mellanox/test_ecn_mode.py
or
Send encapsulated packets to uplink, check that decaplusated packets has different ECN
Details if related